Skip to content

LT-21507: Implement Idle in Pub/Sub system#925

Merged
mark-sil merged 2 commits into
mainfrom
LT-21507
Jun 9, 2026
Merged

LT-21507: Implement Idle in Pub/Sub system#925
mark-sil merged 2 commits into
mainfrom
LT-21507

Conversation

@mark-sil

@mark-sil mark-sil commented Jun 3, 2026 •
edited by jasonleenaylor
Loading

Copy link
Copy Markdown
Contributor

This change is Reviewable

@github-actions

github-actions Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

NUnit Tests

    1 files  ± 0      1 suites  ±0   11m 18s ⏱️ + 1m 5s
4 249 tests +39  4 176 ✅ +36  73 💤 +3  0 ❌ ±0 
4 258 runs  +39  4 185 ✅ +36  73 💤 +3  0 ❌ ±0 

Results for commit 6143f39. ± Comparison against base commit 3f1dc7c.

This pull request removes 2 and adds 41 tests. Note that renamed tests count towards both. 
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RenderEngineFactoryTests ‑ get_Renderer_Graphite
SIL.FieldWorks.Common.RootSites.SimpleRootSiteTests.RenderEngineFactoryTests ‑ get_Renderer_Uniscribe

SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ NormalizePreservingLegacy_NormalizesOpenTypeFeatures
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ NormalizePreservingLegacy_NormalizesOpenTypeFeaturesThatStartWithPunctuation
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ NormalizePreservingLegacy_PreservesNumericGraphiteFeatureIds
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ Normalize_ReturnsDeterministicRendererNeutralString
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ Parse_AcceptsCustomPrintableAsciiTags
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ Parse_IgnoresInvalidEntries
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ Parse_LastValueWinsForDuplicateTags
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ Parse_LogsIgnoredInvalidEntries
SIL.FieldWorks.Common.FwUtils.FontFeatureSettingsTests ‑ Parse_ReturnsNormalizedTagValueSettings
SIL.FieldWorks.Common.RenderVerification.RenderComparisonTests.HarfBuzzSkiaComparisonTests ‑ DrawShapedText_ProducesNonBlankComparisonBitmap
…

♻️ This comment has been updated with latest results.

@johnml1135 johnml1135 requested review from Copilot and johnml1135 June 8, 2026 20:13
Copilot AI reviewed Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@johnml1135 johnml1135 requested a review from Copilot June 8, 2026 20:22
Copilot AI reviewed Jun 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@johnml1135 johnml1135 requested a review from Copilot June 8, 2026 23:27
Copilot AI reviewed Jun 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

@johnml1135 johnml1135 requested a review from Copilot June 8, 2026 23:42
Copilot AI reviewed Jun 8, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment thread Src/XCore/xCoreInterfaces/Mediator.cs
Comment on lines +824 to 828
Trace.WriteLineIf(showPendingMsgsSwitch.TraceVerbose,
BuildDebugMsg("SendMessage::Looking for listeners for Msg: " + messageName),
showPendingMsgsSwitch.DisplayName);
string methodName = "On" + messageName;
// Logging
mark-sil
mark-sil commented Jun 9, 2026
View reviewed changes

@mark-sil mark-sil left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mark-sil resolved 1 discussion.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on johnml1135).

@johnml1135

johnml1135 commented Jun 9, 2026 •
edited by hatton
Loading

Copy link
Copy Markdown
Contributor

:lgtm:

@mark-sil mark-sil merged commit 21b1447 into main Jun 9, 2026
6 of 7 checks passed
@mark-sil mark-sil deleted the LT-21507 branch June 9, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@johnml1135 johnml1135 johnml1135 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mark-sil @johnml1135