Skip to content

Add WinForms MCP and skills#869

Merged
jasonleenaylor merged 2 commits into
mainfrom
LT-22324-agentic-support
Jun 5, 2026
Merged

Add WinForms MCP and skills#869
jasonleenaylor merged 2 commits into
mainfrom
LT-22324-agentic-support

Conversation

@johnml1135

@johnml1135 johnml1135 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR is now scoped just to WinForms MCP and the supporting automation/screenshot skills needed for FieldWorks live UI automation work.

Included

  • Add a FieldWorks WinForms/WinApp automation skill under .github/skills/fieldworks-winapp.
  • Add a Windows-focused screenshot capture skill under .github/skills/smart-screenshot-capture.
  • Add winforms-mcp to .vscode/mcp.json with headless net48 settings.
  • Document WinForms MCP/UIA2 and WinApp/UIA3 fallback usage in Docs/mcp.md.

Excluded

  • Render benchmark infrastructure, render baselines, native render/cache changes, and OpenSpec render-speedup artifacts.
  • Skill relocation to .agents/skills, which remains separate from this PR.
  • LT-22324 font-option implementation behavior.

Verification

  • git diff --name-status cleanup/non-render-pr-split...HEAD
  • git diff --check cleanup/non-render-pr-split...HEAD
  • python -m json.tool .vscode/mcp.json
  • git grep -n "LT-22324" -- .github/skills/fieldworks-winapp returned no matches

This change is Reviewable

Copilot AI review requested due to automatic review settings May 6, 2026 20:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@johnml1135 johnml1135 closed this May 6, 2026
@johnml1135 johnml1135 changed the title LT-22324: add agentic support and render tooling LT-22324: add FieldWorks UI automation support May 7, 2026
@johnml1135 johnml1135 reopened this May 7, 2026
@johnml1135 johnml1135 changed the base branch from main to cleanup/non-render-pr-split May 7, 2026 18:05
@johnml1135 johnml1135 changed the title LT-22324: add FieldWorks UI automation support [1/2] LT-22324: add FieldWorks UI automation support May 7, 2026
@jasonleenaylor

Copy link
Copy Markdown
Contributor

Build/Agent/fix-whitespace.ps1 line 13 at r1 (raw file):

}

function Test-HasUtf8Bom {

Was removing this intentional? It seemed this would produce less churn in the repo with it in.

@johnml1135

Copy link
Copy Markdown
Contributor Author

Good catch. That removal wasn't intentional. I restored the BOM-preserving behavior in Build/Agent/fix-whitespace.ps1 so the whitespace fixer keeps existing UTF-8 BOMs and avoids unnecessary churn. The fix is on the branch now in 47111a3.

@johnml1135 johnml1135 force-pushed the LT-22324-agentic-support branch 2 times, most recently from 70d6808 to 29162e5 Compare May 12, 2026 13:35
@github-actions

This comment has been minimized.

@johnml1135 johnml1135 force-pushed the LT-22324-agentic-support branch 2 times, most recently from b721182 to 3aa324a Compare May 12, 2026 16:37
@johnml1135 johnml1135 force-pushed the cleanup/non-render-pr-split branch from fe6f187 to 2488da1 Compare May 12, 2026 16:37
@johnml1135

Copy link
Copy Markdown
Contributor Author

Follow-up after the PR split cleanup: Build/Agent/fix-whitespace.ps1 is no longer part of #869. This PR now contains only the 12 UI automation support files. The BOM-preserving whitespace-fixer change belongs with the base cleanup layer instead, so if you want to review that script change specifically, please look at the base branch/PR rather than this support-only PR.

@johnml1135 johnml1135 requested a review from Copilot May 12, 2026 20:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

.github/skills/fieldworks-winapp/SKILL.md:1

  • The skill name fieldworks-winapp suggests it is WinApp-only, but the skill is explicitly dual-driver (WinForms MCP + WinApp fallback). Consider renaming the skill to reflect its scope (e.g., fieldworks-ui-automation or fieldworks-winforms-winapp) to avoid incorrect discovery/selection by authors and agents.
---

Comment thread .vscode/mcp.json
Comment thread Docs/mcp.md Outdated
Comment thread Docs/mcp.md Outdated
Comment thread Docs/mcp.md Outdated
@johnml1135 johnml1135 force-pushed the cleanup/non-render-pr-split branch from 2488da1 to daf921a Compare May 12, 2026 20:53
@johnml1135 johnml1135 force-pushed the LT-22324-agentic-support branch from 3aa324a to bc7e8b1 Compare May 12, 2026 23:23
@jasonleenaylor

Copy link
Copy Markdown
Contributor

.github/skills/code-review-skill-main/CONTRIBUTING.md line 1 at r6 (raw file):

# Contributing to AI Code Review Guide

I'm confused about this file.

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 19 files and all commit messages, and made 1 comment.
Reviewable status: 19 of 208 files reviewed, 2 unresolved discussions.


.github/skills/code-review-skill-main/SKILL.md line 1 at r6 (raw file):

---

I have questions about this skill and how/if we should integrate it. It doesn't seem closely related to the automation support yet (still reviewing)

@johnml1135 johnml1135 force-pushed the cleanup/non-render-pr-split branch 2 times, most recently from ff11e68 to 13cdd9c Compare May 20, 2026 23:56
@johnml1135 johnml1135 changed the base branch from cleanup/non-render-pr-split to main May 21, 2026 17:42
@johnml1135 johnml1135 changed the title [1/2] LT-22324: add FieldWorks UI automation support Add FieldWorks UI automation support May 21, 2026
@johnml1135 johnml1135 force-pushed the LT-22324-agentic-support branch from 623fb0e to 45ed34a Compare May 21, 2026 17:42
@johnml1135 johnml1135 changed the title Add FieldWorks UI automation support Add WinForms MCP and skills May 21, 2026
@github-actions

github-actions Bot commented May 21, 2026

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   12m 16s ⏱️ +28s
4 210 tests ±0  4 140 ✅ ±0  70 💤 ±0  0 ❌ ±0 
4 219 runs  ±0  4 149 ✅ ±0  70 💤 ±0  0 ❌ ±0 

Results for commit ff471a9. ± Comparison against base commit 53d5dbb.

♻️ This comment has been updated with latest results.

@johnml1135

Copy link
Copy Markdown
Contributor Author

.github/skills/code-review-skill-main/CONTRIBUTING.md line 1 at r6 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I'm confused about this file.

Moved to the review skills PR.

@johnml1135

Copy link
Copy Markdown
Contributor Author

.github/skills/code-review-skill-main/SKILL.md line 1 at r6 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…

I have questions about this skill and how/if we should integrate it. It doesn't seem closely related to the automation support yet (still reviewing)

Moved to the review skills PR.

@johnml1135 johnml1135 force-pushed the LT-22324-agentic-support branch from 45ed34a to ff471a9 Compare June 4, 2026 17:33
@johnml1135

Copy link
Copy Markdown
Contributor Author

@jasonleenaylor - what else needs to be done for this one?

@jasonleenaylor jasonleenaylor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonleenaylor reviewed 207 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on johnml1135).

@jasonleenaylor jasonleenaylor merged commit 274c1cc into main Jun 5, 2026
7 checks passed
@jasonleenaylor jasonleenaylor deleted the LT-22324-agentic-support branch June 5, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants