From 553cf47b078cbf720cdab8ee36538fad11374ec5 Mon Sep 17 00:00:00 2001 From: Arbian Shkodra Date: Tue, 10 Nov 2026 18:04:53 +0100 Subject: [PATCH] ci(workflows): pass the App's client-id to create-github-app-token, pinned at v3.3.0 The action deprecated `app-id` in v3.1.0 in favour of `client-id`, and every run has printed the warning since. The input takes the App's Client ID or its numeric App ID (either is the JWT issuer GitHub accepts), so the existing secret keeps working under the new name, and its value can move to the Client ID later with no workflow change. Where the pin was fee1f7d6, that commit is v2.2.2, not the v3.3.0 the comment claimed; v3.3.0 is 64ab729a. The inputs are the same across the two majors, and v3's breaking changes (Node 24 runtime, proxy env) do not touch GitHub-hosted runners. Co-Authored-By: Claude Fable 5.1 --- .github/workflows/release-please.yml | 4 ++-- .github/workflows/seal-dispatch.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index 28eda487a..65d2f3852 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -23,9 +23,9 @@ jobs: # token does neither. id: app if: env.HAS_APP == 'true' - uses: actions/create-github-app-token@fee1f7d63c2ff003460e3d139729b119787bc349 # v3.3.0 + uses: actions/create-github-app-token@64ab729a6294000f5aa4a4bc0b73d1f32bc45510 # v3.3.0 with: - app-id: ${{ secrets.SDK_APP_ID }} + client-id: ${{ secrets.SDK_APP_ID }} private-key: ${{ secrets.SDK_APP_PRIVATE_KEY }} owner: sentdm repositories: ${{ github.event.repository.name }} diff --git a/.github/workflows/seal-dispatch.yml b/.github/workflows/seal-dispatch.yml index 897966a82..72fe7edda 100644 --- a/.github/workflows/seal-dispatch.yml +++ b/.github/workflows/seal-dispatch.yml @@ -40,9 +40,9 @@ jobs: - name: Mint a pipeline token from the GitHub App id: app if: env.HAS_APP == 'true' - uses: actions/create-github-app-token@fee1f7d63c2ff003460e3d139729b119787bc349 # v3.3.0 + uses: actions/create-github-app-token@64ab729a6294000f5aa4a4bc0b73d1f32bc45510 # v3.3.0 with: - app-id: ${{ secrets.SDK_APP_ID }} + client-id: ${{ secrets.SDK_APP_ID }} private-key: ${{ secrets.SDK_APP_PRIVATE_KEY }} owner: sentdm repositories: sent-dm-sdk-pipeline