From 2ee7b510919ca0f5679a62092a2a8cf5531a7fa9 Mon Sep 17 00:00:00 2001
From: gpotter2 <10530980+gpotter2@users.noreply.github.com>
Date: Fri, 13 Nov 2026 00:46:48 +0100
Subject: [PATCH] ldaphero: add 'no check certificate' box

AI-Assisted: no
---
 scapy/modules/ldaphero.py | 24 +++++++++++++++++++-----
 1 file changed, 19 insertions(+), 5 deletions(-)

diff --git a/scapy/modules/ldaphero.py b/scapy/modules/ldaphero.py
index a2a269187d5..f9d0e701a62 100644
--- a/scapy/modules/ldaphero.py
+++ b/scapy/modules/ldaphero.py
@@ -159,6 +159,7 @@ def __init__(
         host: str = None,
         port: int = None,
         ssl: bool = False,
+        no_check_certificate=False,
         # Authentication
         UPN: str = None,
         password: str = None,
@@ -203,6 +204,7 @@ def __init__(
         self.host = host
         self.port = port
         self.ssl = ssl
+        self.no_check_certificate = no_check_certificate
         self.dns_domain_name = ""
         self.rootDSE = {}
         self.sids = dict(WELL_KNOWN_SIDS)
@@ -241,11 +243,17 @@ def connect(self):
             tk.Entry(dlg, textvariable=portv).grid(row=1, column=1)
 
             sslv = tk.BooleanVar()
+            sslv.set(self.ssl)
             ttk.Label(dlg, text="SSL").grid(row=2, column=0)
             ttk.Checkbutton(dlg, variable=sslv).grid(row=2, column=1)
 
-            ttk.Button(dlg, text="OK", command=popup.dismiss).grid(row=3, column=0)
-            ttk.Button(dlg, text="Cancel", command=popup.cancel).grid(row=3, column=1)
+            nccv = tk.BooleanVar()
+            nccv.set(self.no_check_certificate)
+            ttk.Label(dlg, text="Do not check certificate").grid(row=3, column=0)
+            ttk.Checkbutton(dlg, variable=nccv).grid(row=3, column=1)
+
+            ttk.Button(dlg, text="OK", command=popup.dismiss).grid(row=4, column=0)
+            ttk.Button(dlg, text="Cancel", command=popup.cancel).grid(row=4, column=1)
 
             serverf.focus()
 
@@ -261,14 +269,20 @@ def connect(self):
             except ValueError:
                 return
             self.ssl = sslv.get()
+            self.no_check_certificate = nccv.get()
 
         # Connect now !
         self.tprint(
-            "client.connect(host='%s', port=%s, ssl=%s)"
-            % (self.host, self.port, self.ssl)
+            "client.connect(host='%s', port=%s, ssl=%s, no_check_certificate=%s)"
+            % (self.host, self.port, self.ssl, self.no_check_certificate)
         )
         try:
-            self.client.connect(self.host, port=self.port, use_ssl=self.ssl)
+            self.client.connect(
+                self.host,
+                port=self.port,
+                use_ssl=self.ssl,
+                no_check_certificate=self.no_check_certificate,
+            )
         except Exception as ex:
             self.tprint(str(ex))
             self.host = None