From 0b534582fc7da7a137063509b18f063cf8c5abfb Mon Sep 17 00:00:00 2001 From: Edgar Arakelyan Date: Wed, 18 Nov 2026 16:43:12 -0800 Subject: [PATCH] fix(release): push chromium's index without annotations, which buildx refuses on a Docker manifest list A compose pushes each arch's image with docker push, so the images have Docker media types, and the buildx on GitHub's newer runner image (20261116.202.1) refuses index annotations over a Docker manifest list. v0.9.1573's computer-publish failed that way and the release recorded no chromium. agentenv-chromium is already public and linked to the repo, and the annotations were metadata only. Co-Authored-By: Claude Opus 5.5 --- .github/scripts/infra_build.py | 4 +--- tst/unit/test_infra_build_script.py | 2 -- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/scripts/infra_build.py b/.github/scripts/infra_build.py index d1cee0cc6..4be691415 100644 --- a/.github/scripts/infra_build.py +++ b/.github/scripts/infra_build.py @@ -316,11 +316,9 @@ def _publish_computers(folder: Path) -> int: if served is None and ": not found" not in error: print(f"::warning::{index} is taken as unpublished, since the registry won't say: {error}") if served is None: - source = f"https://github.com/{os.environ['GITHUB_REPOSITORY']}" + # No --annotation: a compose pushes Docker media types, and buildx refuses annotations on a Docker list. created = _tried_again(lambda: _streamed([ "docker", "buildx", "imagetools", "create", "-t", index, - "--annotation", f"index:org.opencontainers.image.source={source}", - "--annotation", f"index:org.opencontainers.image.revision={os.environ['GITHUB_SHA']}", *(f"localhost:5000/agentenv-computers@{digests[arch]}" for arch in COMPUTER_ARCHES)])) if created.returncode: return created.returncode diff --git a/tst/unit/test_infra_build_script.py b/tst/unit/test_infra_build_script.py index 6b34b9a76..cc3a3706d 100644 --- a/tst/unit/test_infra_build_script.py +++ b/tst/unit/test_infra_build_script.py @@ -381,8 +381,6 @@ def test_publish_computers_joins_each_apps_platform_manifests_into_one_index_and assert _run(script, monkeypatch, "publish-computers", str(folder)) == 0 assert created == [["docker", "buildx", "imagetools", "create", "-t", _COMPUTER_INDEX, - "--annotation", "index:org.opencontainers.image.source=https://github.com/scaleapi/agentenv-framework", - "--annotation", "index:org.opencontainers.image.revision=c0ffee", f"{_LOCAL}@{_AMD64}", f"{_LOCAL}@{_ARM64}"]] computers = json.loads((folder / "computers.json").read_text()) assert computers == [{"env": CHROMIUM, "form": "container", "index": f"{_COMPUTER_INDEX}@{_INDEX}", "arches": {