From 761b2a5d2a461b2dfef32e5a28c66f62c3296e67 Mon Sep 17 00:00:00 2001 From: Ryan Magoon Date: Mon, 3 Aug 2026 23:41:03 -0400 Subject: [PATCH 1/3] Explain surprising changes at review time --- .chezmoitemplates/ai/coding-principles.md | 4 ++++ .chezmoitemplates/ai/git-workflow.md | 1 + 2 files changed, 5 insertions(+) diff --git a/.chezmoitemplates/ai/coding-principles.md b/.chezmoitemplates/ai/coding-principles.md index 72fa676..265f396 100644 --- a/.chezmoitemplates/ai/coding-principles.md +++ b/.chezmoitemplates/ai/coding-principles.md @@ -39,6 +39,10 @@ When your changes create orphans: The test: Every changed line should trace directly to the user's request. +## Managed Personal Configuration + +- Before editing a user-level configuration file, check whether chezmoi manages it with `chezmoi source-path `. If it does, edit the source file, review `chezmoi diff`, run `chezmoi apply --dry-run -v`, and then apply it. Never leave a target-only edit that the next chezmoi apply will overwrite. + ## Diagnose Before Fixing **Measure first. Don't theorize about the cause of a bug when you can instrument and observe.** diff --git a/.chezmoitemplates/ai/git-workflow.md b/.chezmoitemplates/ai/git-workflow.md index b2a5edf..4275c3d 100644 --- a/.chezmoitemplates/ai/git-workflow.md +++ b/.chezmoitemplates/ai/git-workflow.md @@ -9,3 +9,4 @@ ## Pull Requests - **Always squash merge PRs.** Use `gh pr merge --squash` (or the GitHub UI squash-and-merge option) so each PR lands on `main` as a single, clean commit. This keeps `main` history readable regardless of how many granular commits the working branch had. +- **Explain surprising choices where the reviewer sees them.** If a dependency, flag, workaround, suppression, or implementation choice looks unused or wrong without hidden context, add a concise inline GitHub comment on the relevant diff line. State what loads or requires it and why the obvious alternative was not used. Do not make reviewers reconstruct intent from tooling internals or the PR description. From 10141568af82f565976c5db98960451c06804c40 Mon Sep 17 00:00:00 2001 From: Ryan Magoon Date: Mon, 3 Aug 2026 23:59:42 -0400 Subject: [PATCH 2/3] Treat dotfiles as public --- .chezmoitemplates/ai/coding-principles.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.chezmoitemplates/ai/coding-principles.md b/.chezmoitemplates/ai/coding-principles.md index 265f396..a5f3c24 100644 --- a/.chezmoitemplates/ai/coding-principles.md +++ b/.chezmoitemplates/ai/coding-principles.md @@ -42,6 +42,7 @@ The test: Every changed line should trace directly to the user's request. ## Managed Personal Configuration - Before editing a user-level configuration file, check whether chezmoi manages it with `chezmoi source-path `. If it does, edit the source file, review `chezmoi diff`, run `chezmoi apply --dry-run -v`, and then apply it. Never leave a target-only edit that the next chezmoi apply will overwrite. +- Treat the chezmoi source as public. Never add employer-specific names, internal URLs, issue keys, repository names, source code, architecture details, customer data, credentials, or other non-public business information. Keep reusable instructions generic. If a rule cannot be made generic without losing its meaning, keep it out of dotfiles. ## Diagnose Before Fixing From 026ecbc033d206167a333cbc1ee6bd9f9686150f Mon Sep 17 00:00:00 2001 From: Ryan Magoon Date: Tue, 4 Aug 2026 11:36:44 -0400 Subject: [PATCH 3/3] Screen public GitHub metadata --- .chezmoitemplates/ai/coding-principles.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.chezmoitemplates/ai/coding-principles.md b/.chezmoitemplates/ai/coding-principles.md index a5f3c24..e65cfbd 100644 --- a/.chezmoitemplates/ai/coding-principles.md +++ b/.chezmoitemplates/ai/coding-principles.md @@ -43,6 +43,7 @@ The test: Every changed line should trace directly to the user's request. - Before editing a user-level configuration file, check whether chezmoi manages it with `chezmoi source-path `. If it does, edit the source file, review `chezmoi diff`, run `chezmoi apply --dry-run -v`, and then apply it. Never leave a target-only edit that the next chezmoi apply will overwrite. - Treat the chezmoi source as public. Never add employer-specific names, internal URLs, issue keys, repository names, source code, architecture details, customer data, credentials, or other non-public business information. Keep reusable instructions generic. If a rule cannot be made generic without losing its meaning, keep it out of dotfiles. +- Apply the same public-information check to every GitHub surface for the dotfiles repository, including branch names, commit messages, pull request titles and descriptions, review comments, issues, and releases. Describe only the generic change and its public rationale. Never publish the private repository, incident, conversation, or business context that prompted it. ## Diagnose Before Fixing