#69635 (a rollup) caused a small performance regression. Since the regression has persisted through the last half dozen perf runs, it is likely not spurious. There are no outstanding perf runs near the regression (2020-03-02), so I am fairly confident in this attribution. That rollup consists of the following PRs:
I would not expect any of them to negatively impact performance, although I did do a perf run with an unchecked_add in Layout::repeat to no avail (see #69679). The regression is only noticeable in clean/patched incremental builds, so I don't think this is high priority, but it would be nice to know what's going on here.
cc @nnethercote @jonas-schievink @Mark-Simulacrum
#69635 (a rollup) caused a small performance regression. Since the regression has persisted through the last half dozen perf runs, it is likely not spurious. There are no outstanding perf runs near the regression (2020-03-02), so I am fairly confident in this attribution. That rollup consists of the following PRs:
checked_addinLayout::repeat" #69544 (Unrevert "Removechecked_addinLayout::repeat")syntaxin librustc_ast/README.md #69622 (Renamesyntaxin librustc_ast/README.md)I would not expect any of them to negatively impact performance, although I did do a perf run with an
unchecked_addinLayout::repeatto no avail (see #69679). The regression is only noticeable in clean/patched incremental builds, so I don't think this is high priority, but it would be nice to know what's going on here.cc @nnethercote @jonas-schievink @Mark-Simulacrum