<%= f.label :payment_due_deadline_date, "Payment due by", class: "block font-medium mb-1" %>
diff --git a/spec/models/event_spec.rb b/spec/models/event_spec.rb
index 42036a36d6..2714692c16 100644
--- a/spec/models/event_spec.rb
+++ b/spec/models/event_spec.rb
@@ -363,6 +363,81 @@
end
end
+ describe "discount code" do
+ describe "validations" do
+ it "allows alphanumeric codes with hyphens and underscores" do
+ event = build(:event, discount_code: "SAVE50-ABC_123")
+ expect(event).to be_valid
+ end
+
+ it "allows blank codes" do
+ event = build(:event, discount_code: "")
+ expect(event).to be_valid
+ end
+
+ it "rejects codes with spaces" do
+ event = build(:event, discount_code: "SAVE 50")
+ expect(event).not_to be_valid
+ expect(event.errors[:discount_code]).to be_present
+ end
+
+ it "rejects codes with URL-unsafe characters" do
+ event = build(:event, discount_code: "SAVE?50&x=y")
+ expect(event).not_to be_valid
+ expect(event.errors[:discount_code]).to be_present
+ end
+ end
+
+ describe "#discount_code?" do
+ it "returns true when code and amount are present" do
+ event = build(:event, discount_code: "SAVE50", discount_amount_cents: 2500)
+ expect(event.discount_code?).to be true
+ end
+
+ it "returns false when code is blank" do
+ event = build(:event, discount_code: nil, discount_amount_cents: 2500)
+ expect(event.discount_code?).to be false
+ end
+
+ it "returns false when amount is zero" do
+ event = build(:event, discount_code: "SAVE50", discount_amount_cents: 0)
+ expect(event.discount_code?).to be false
+ end
+ end
+
+ describe "#discount_amount" do
+ it "converts cents to dollars" do
+ event = build(:event, discount_amount_cents: 2500)
+ expect(event.discount_amount).to eq(25.0)
+ end
+
+ it "returns nil when blank" do
+ event = build(:event, discount_amount_cents: nil)
+ expect(event.discount_amount).to be_nil
+ end
+ end
+
+ describe "#discount_amount=" do
+ it "converts dollar amount to cents" do
+ event = build(:event)
+ event.discount_amount = 25.0
+ expect(event.discount_amount_cents).to eq(2500)
+ end
+
+ it "handles string input" do
+ event = build(:event)
+ event.discount_amount = "10.99"
+ expect(event.discount_amount_cents).to eq(1099)
+ end
+
+ it "sets nil when blank" do
+ event = build(:event)
+ event.discount_amount = ""
+ expect(event.discount_amount_cents).to be_nil
+ end
+ end
+ end
+
describe "#build_public_registration_form" do
let!(:default_form) { create(:form, name: "Short Event Registration") }
let!(:extended_form) { create(:form, name: "Extended Event Registration") }
diff --git a/spec/requests/events/public_registrations_spec.rb b/spec/requests/events/public_registrations_spec.rb
index 5f2c90b629..a686f127e8 100644
--- a/spec/requests/events/public_registrations_spec.rb
+++ b/spec/requests/events/public_registrations_spec.rb
@@ -971,4 +971,100 @@ def field(identifier)
expect(unstamped.map(&:first)).to be_empty
end
end
+
+ describe "discount code" do
+ let(:event) { create(:event, cost_cents: 10_000, discount_code: "SAVE50", discount_amount_cents: 2500) }
+ let(:user) { create(:user, :with_person) }
+ let(:form) { create(:form) }
+ let!(:essay_field) do
+ create(:form_field, form: form, answer_type: :free_form_input_paragraph,
+ name: "Tell us why", required: true, min_words: 5)
+ end
+ let!(:first_name_field) do
+ create(:form_field, form: form, field_identifier: "first_name", name: "First name", required: false)
+ end
+ let!(:last_name_field) do
+ create(:form_field, form: form, field_identifier: "last_name", name: "Last name", required: false)
+ end
+ let!(:email_field) do
+ create(:form_field, form: form, field_identifier: "primary_email", name: "Email", required: false)
+ end
+ let!(:payment_method_field) do
+ field = create(:form_field, form: form, field_identifier: "payment_method",
+ name: "Payment method", required: false)
+ FormBuilderService::PAYMENT_METHOD_OPTIONS.each do |option_name|
+ field.form_field_answer_options.create!(answer_option: AnswerOption.find_or_create_by!(name: option_name))
+ end
+ field
+ end
+ let(:fake_session) { double(url: "https://checkout.stripe.com/test", id: "cs_test_123") }
+
+ before do
+ fake_processor = double(checkout: fake_session)
+ allow_any_instance_of(Person).to receive(:set_payment_processor)
+ allow_any_instance_of(Person).to receive(:payment_processor).and_return(fake_processor)
+ end
+
+ def post_with_code(code: nil, payment: nil)
+ fields = {
+ essay_field.id.to_s => "this answer has enough words for validation",
+ first_name_field.id.to_s => "Pat",
+ last_name_field.id.to_s => "Lee",
+ email_field.id.to_s => "pat-#{SecureRandom.hex(4)}@example.com"
+ }
+ fields[payment_method_field.id.to_s] = payment if payment
+
+ params = { public_registration: { Honeypot::FIELD_NAME => "", form_fields: fields } }
+ params[:discount_code] = code if code
+
+ post event_public_registration_path(event), params: params
+ end
+
+ it "creates a discount allocation when code matches" do
+ expect {
+ post_with_code(code: "SAVE50", payment: "Credit card (now)")
+ }.to change(Discount, :count).by(1)
+ .and change(Allocation, :count).by(1)
+
+ registration = EventRegistration.last
+ expect(registration.discount_sum).to eq(2500)
+ expect(registration.remaining_cost).to eq(7500)
+ end
+
+ it "charges the discounted amount to Stripe" do
+ captured = nil
+ fake_processor = double
+ allow(fake_processor).to receive(:checkout) { |args| captured = args; fake_session }
+ allow_any_instance_of(Person).to receive(:payment_processor).and_return(fake_processor)
+
+ post_with_code(code: "SAVE50", payment: "Credit card (now)")
+
+ expect(captured[:line_items].first[:price_data][:unit_amount]).to eq(7500)
+ end
+
+ it "ignores an invalid code" do
+ expect {
+ post_with_code(code: "WRONG", payment: "Credit card (now)")
+ }.not_to change(Discount, :count)
+
+ registration = EventRegistration.last
+ expect(registration.remaining_cost).to eq(10_000)
+ end
+
+ it "matches case-insensitively" do
+ expect {
+ post_with_code(code: "save50", payment: "Credit card (now)")
+ }.to change(Discount, :count).by(1)
+
+ expect(EventRegistration.last.discount_sum).to eq(2500)
+ end
+
+ it "does not create a discount when event has no code" do
+ event.update!(discount_code: nil, discount_amount_cents: nil)
+
+ expect {
+ post_with_code(code: "SAVE50")
+ }.not_to change(Discount, :count)
+ end
+ end
end
From c036735427898cf1ea2e264fb31c370fd968b5c1 Mon Sep 17 00:00:00 2001
From: Justin Miller <16829344+jmilljr24@users.noreply.github.com>
Date: Fri, 4 Sep 2026 12:26:04 -0400
Subject: [PATCH 5/5] clean up
---
app/models/event.rb | 2 --
1 file changed, 2 deletions(-)
diff --git a/app/models/event.rb b/app/models/event.rb
index e0765be69d..704de50eea 100644
--- a/app/models/event.rb
+++ b/app/models/event.rb
@@ -479,8 +479,6 @@ def ce_hours_cost=(dollar_amount)
end
end
- # Virtual attribute for discount amount in dollars (converts to/from
- # discount_amount_cents), mirroring #cost.
def discount_amount
return nil if discount_amount_cents.nil?
discount_amount_cents / 100.0