From ccb860ffdd9471c6b26e1c7bd416b3c1124e9d55 Mon Sep 17 00:00:00 2001 From: Danilo Piparo Date: Wed, 18 Nov 2026 09:46:26 +0100 Subject: [PATCH 1/3] [ci] Properly access the INCREMENTAL env variable on Windows --- .github/workflows/root-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/root-ci.yml b/.github/workflows/root-ci.yml index 0fae71f9d7bdd..3f2ecc76b40e9 100644 --- a/.github/workflows/root-ci.yml +++ b/.github/workflows/root-ci.yml @@ -306,7 +306,7 @@ jobs: python .github/workflows/root-ci-config/build_root.py --buildtype ${{ matrix.config }} --platform windows10 - --incremental $INCREMENTAL + --incremental %INCREMENTAL% --base_ref ${{ github.base_ref }} --sha ${{ github.sha }} --pull_repository ${{ github.event.pull_request.head.repo.clone_url }} From 847789c046acfded9a9e99207eeed88a74960cb3 Mon Sep 17 00:00:00 2001 From: Danilo Piparo Date: Thu, 19 Nov 2026 10:14:19 +0100 Subject: [PATCH 2/3] [ci] Adapt git command for Windows --- .github/workflows/root-ci-config/build_root.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/root-ci-config/build_root.py b/.github/workflows/root-ci-config/build_root.py index 7ae789e70baf6..62ccfbf6e08c2 100755 --- a/.github/workflows/root-ci-config/build_root.py +++ b/.github/workflows/root-ci-config/build_root.py @@ -319,7 +319,7 @@ def git_pull(directory: str, repository: str, branch: str): cd '{targetdir}' git checkout {branch} git fetch - git reset --hard @{{u}} + git reset --hard '@{{u}}' """) else: returncode = subprocess_with_log(f""" From 3d46c538556e020b05e7f8143121ac54589dbc02 Mon Sep 17 00:00:00 2001 From: Danilo Piparo Date: Thu, 19 Nov 2026 10:59:56 +0100 Subject: [PATCH 3/3] [ci] Chunk artifacts download To support payloads larger than 4 GB on 32 bits platforms --- .github/workflows/root-ci-config/build_utils.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/root-ci-config/build_utils.py b/.github/workflows/root-ci-config/build_utils.py index 5ace08990c732..a9a7383a50b28 100755 --- a/.github/workflows/root-ci-config/build_utils.py +++ b/.github/workflows/root-ci-config/build_utils.py @@ -312,8 +312,13 @@ def download_file(url: str, dest: str) -> None: if not os.path.exists(parent_dir): os.makedirs(parent_dir) - with open(dest, 'wb') as fout, get(url, timeout=300) as req: - fout.write(req.content) + # We need to download in chunks for 32 bits platforms and payloads + # larger than 4 GB + with get(url, timeout=300, stream=True) as req: + req.raise_for_status() + with open(dest, 'wb') as fout: + for chunk in req.iter_content(chunk_size=1 << 20): + fout.write(chunk) def download_latest(url: str, prefix: str, destination: str) -> str: