From bffbb3b160923fc31e6dd76b3783fa896f7ddc91 Mon Sep 17 00:00:00 2001 From: Brandur Date: Fri, 21 Aug 2026 06:05:52 +0800 Subject: [PATCH] Have SQLite driver always return non-null errors to match Postgres This one's related to [1]. Have the SQLite driver always return a non-null errors property to match the Postgres behavior. [1] https://github.com/riverqueue/riverui/pull/657#discussion_r3822027754 --- riverdriver/riverdrivertest/job_insert.go | 1 + riverdriver/riversqlite/river_sqlite_driver.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/riverdriver/riverdrivertest/job_insert.go b/riverdriver/riverdrivertest/job_insert.go index ee4fa745..d325e2e4 100644 --- a/riverdriver/riverdrivertest/job_insert.go +++ b/riverdriver/riverdrivertest/job_insert.go @@ -602,6 +602,7 @@ func exerciseJobInsert[TTx any](ctx context.Context, t *testing.T, require.Nil(t, job.AttemptedAt) require.WithinDuration(t, time.Now().UTC(), job.CreatedAt, 2*time.Second) require.JSONEq(t, `{"encoded": "args"}`, string(job.EncodedArgs)) + require.NotNil(t, job.Errors) require.Empty(t, job.Errors) require.Nil(t, job.FinalizedAt) require.Equal(t, "test_kind", job.Kind) diff --git a/riverdriver/riversqlite/river_sqlite_driver.go b/riverdriver/riversqlite/river_sqlite_driver.go index 3499dae8..97811a25 100644 --- a/riverdriver/riversqlite/river_sqlite_driver.go +++ b/riverdriver/riversqlite/river_sqlite_driver.go @@ -1622,7 +1622,7 @@ func jobRowFromInternal(internal *dbsqlc.RiverJob) (*rivertype.JobRow, error) { } } - var errors []rivertype.AttemptError + errors := make([]rivertype.AttemptError, 0) if internal.Errors != nil { if err := json.Unmarshal(internal.Errors, &errors); err != nil { return nil, fmt.Errorf("error unmarshaling `errors`: %w", err)