Skip to content

pull-requests.md

Latest commit

 

History

History
16 lines (15 loc) · 1.09 KB

pull-requests.md

File metadata and controls

16 lines (15 loc) · 1.09 KB
Raw

How to Create a Pull Request on RERO+ github projects

  1. Test your PR from scratch locally: bootstrap, setup and test the part of the interface touched by your work
  2. Create the PR in Draft mode
  3. Make sure your branch is up-to-date with the desired branch (parent branch you come from)
  4. Make sure you do not have extra commits to squash
  5. Review your own PR first
    1. If an LLM helped you write the code, you MUST have read and understood what you commit BEFORE calling other reviewers!
  6. Update the commit message after the review to be sure that all what you have done is described
  7. Check that the Github Actions tests are successfull
  8. Remove the draft mode
  9. Wait for CodeRabbit to review your PR, and make any fixes necessary
  10. Call 1-2 pertinent team members for review
    1. For large code changes (100+ lines) or when you are not entirely sure about your changes, speak with the team about what you did and what they should pay attention to.
  11. If you need PO tests, ask for local testing or deploy to a dev server.
  12. When your PR is approved and tested, do a rebase and merge.