diff --git a/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc new file mode 100644 index 00000000000..3e3af9ff872 --- /dev/null +++ b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/asymmetric_visibility.php.inc @@ -0,0 +1,35 @@ + +----- + diff --git a/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc new file mode 100644 index 00000000000..07a84d33a71 --- /dev/null +++ b/rules-tests/Privatization/Rector/Property/PrivatizeFinalClassPropertyRector/Fixture/skip_public_asymmetric_visibility.php.inc @@ -0,0 +1,15 @@ +replaceVisibilityFlag($node, Visibility::PRIVATE); + // private property cannot have wider set visibility, and private(set) is redundant + if ($node instanceof Property || $node instanceof Param) { + $node->flags &= ~Modifiers::VISIBILITY_SET_MASK; + } + // only constructor can be both private and final if ($node instanceof ClassMethod && $this->nodeNameResolver->isName($node, MethodName::CONSTRUCT)) { return;