From e9e052d992b3d341969af8d8da62621d0d8dc187 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Thu, 12 Nov 2026 12:56:37 +0100 Subject: [PATCH 1/2] [tests] extend real class --- .../NewTypeResolver/Source/NewDynamicNewExtends.php | 2 +- .../NewTypeResolver/Source/SomeRealType.php | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/SomeRealType.php diff --git a/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/NewDynamicNewExtends.php b/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/NewDynamicNewExtends.php index 147dd6db808..97054e28c0a 100644 --- a/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/NewDynamicNewExtends.php +++ b/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/NewDynamicNewExtends.php @@ -6,6 +6,6 @@ final class NewDynamicNewExtends { public function run() { - new class extends \Symfony\Bundle\TwigBundle\Loader\FilesystemLoader {}; + new class extends SomeRealType {}; } } diff --git a/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/SomeRealType.php b/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/SomeRealType.php new file mode 100644 index 00000000000..e52745b652d --- /dev/null +++ b/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/Source/SomeRealType.php @@ -0,0 +1,8 @@ + Date: Sat, 14 Nov 2026 14:15:50 +0100 Subject: [PATCH 2/2] update NewTypeResolverTest expectation to SomeRealType parent --- .../NewTypeResolver/NewTypeResolverTest.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/NewTypeResolverTest.php b/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/NewTypeResolverTest.php index 6cd754433cd..1571a0edfeb 100644 --- a/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/NewTypeResolverTest.php +++ b/tests/NodeTypeResolver/PerNodeTypeResolver/NewTypeResolver/NewTypeResolverTest.php @@ -13,6 +13,7 @@ use Rector\NodeTypeResolver\PHPStan\ObjectWithoutClassTypeWithParentTypes; use Rector\StaticTypeMapper\ValueObject\Type\FullyQualifiedObjectType; use Rector\Tests\NodeTypeResolver\PerNodeTypeResolver\AbstractNodeTypeResolverTestCase; +use Rector\Tests\NodeTypeResolver\PerNodeTypeResolver\NewTypeResolver\Source\SomeRealType; /** * @see \Rector\NodeTypeResolver\NodeTypeResolver\NewTypeResolver @@ -31,7 +32,7 @@ public function test(string $file, int $nodePosition, Type $expectedType, bool $ $isObjectType, $this->nodeTypeResolver->isObjectType( $newNodes[$nodePosition], - new ObjectType('Symfony\Bundle\TwigBundle\Loader\FilesystemLoader') + new ObjectType(SomeRealType::class) ) ); } @@ -47,7 +48,7 @@ public static function provideData(): Iterator yield [__DIR__ . '/Source/NewDynamicNew.php', 0, $objectWithoutClassType, false]; $objectWithoutClassTypeWithParentTypes = new ObjectWithoutClassTypeWithParentTypes( - [new FullyQualifiedObjectType('Symfony\Bundle\TwigBundle\Loader\FilesystemLoader')] + [new FullyQualifiedObjectType(SomeRealType::class)] ); yield [__DIR__ . '/Source/NewDynamicNewExtends.php', 0, $objectWithoutClassTypeWithParentTypes, true]; }