From 251edcd511649eea2c61bbd2383324f03a5578d4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Fri, 18 Sep 2026 05:07:29 -0700 Subject: [PATCH 1/2] Use public umbrellas in modal headers (#58570) Summary: Route public C++ dependencies through their supported umbrella entry points so framework consumers can use the modal module with strict API enforcement enabled. Changelog: [Internal] Differential Revision: D120528333 --- .../components/modal/ModalHostViewComponentDescriptor.h | 2 +- .../react/renderer/components/modal/ModalHostViewShadowNode.h | 2 +- .../react/renderer/components/modal/ModalHostViewState.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewComponentDescriptor.h b/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewComponentDescriptor.h index 095c60b26432..7300b59588cd 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewComponentDescriptor.h +++ b/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewComponentDescriptor.h @@ -9,9 +9,9 @@ #include +#include #include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewShadowNode.h b/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewShadowNode.h index 0219d44ca775..0b767161d136 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewShadowNode.h +++ b/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewShadowNode.h @@ -9,10 +9,10 @@ #include +#include #include #include #include -#include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.h b/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.h index 4b12b0539692..f85268778d7e 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.h +++ b/packages/react-native/ReactCommon/react/renderer/components/modal/ModalHostViewState.h @@ -9,7 +9,7 @@ #include -#include +#include #include #include "ModalHostViewUtils.h" From c499fc956e9815ec49c3a0e735f2ecc3aa97d07e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Fri, 18 Sep 2026 05:07:29 -0700 Subject: [PATCH 2/2] Make RendererCore conversions Apple warning-clean Summary: Add safe fallback cases to RendererCore enum conversions so public umbrella consumers compile with Apple's -Wswitch-default policy. Changelog: [Internal] Differential Revision: D120687424 --- .../ReactCommon/react/renderer/core/conversions.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/core/conversions.h b/packages/react-native/ReactCommon/react/renderer/core/conversions.h index ef7c241da78b..74e5fe9e01a3 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/core/conversions.h @@ -22,6 +22,8 @@ inline std::string toString(const LayoutDirection &layoutDirection) return "ltr"; case LayoutDirection::RightToLeft: return "rtl"; + default: + return "undefined"; } } @@ -34,6 +36,8 @@ inline int toInt(const LayoutDirection &layoutDirection) return 1; case LayoutDirection::RightToLeft: return 2; + default: + return 0; } } @@ -48,6 +52,8 @@ inline int toInt(const DisplayType &displayType) return 2; case DisplayType::Grid: return 3; + default: + return 0; } } @@ -62,6 +68,8 @@ inline std::string toString(const DisplayType &displayType) return "contents"; case DisplayType::Grid: return "grid"; + default: + return "none"; } }