From f1c27cb50a06fdb11199de8693b4c075d5a331a8 Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Fri, 26 Jun 2026 16:58:38 +0000 Subject: [PATCH] fix: repair cross-package bugs and test config in monorepo - api.ts: import useDebounce (hook was renamed from useThrottle) - Button: forward aria-label for accessible name on icon-only buttons - DataTable: use functional setState to fix stale-closure sort toggle - date.ts: use dateStyle:'short' so en-AU yields day-first ordering - bunfig.toml: preload happy-dom GlobalRegistrator so DOM globals exist - tsconfig.json: add bun-types so bun:test resolves --- apps/web/src/lib/api.ts | 4 ++-- bunfig.toml | 3 ++- packages/ui/src/components/Button/Button.tsx | 3 +-- packages/ui/src/components/DataTable/DataTable.tsx | 2 +- packages/utils/src/format/date.ts | 4 +--- tsconfig.json | 1 + 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..4df4cfc 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -8,7 +8,7 @@ */ // BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -29,4 +29,4 @@ export async function fetchPosts() { export { formatDate, formatAUD } // Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..26b14f2 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,3 @@ [test] -environment = "happy-dom" \ No newline at end of file +environment = "happy-dom" +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..eba35da 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -39,8 +39,7 @@ export function Button({ className={`btn btn-${variant}`} disabled={disabled} onClick={onClick} - // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed - // The component should enforce aria-label for icon-only buttons + aria-label={iconOnly ? (ariaLabel ?? "button") : ariaLabel} > {icon && {icon}} {!iconOnly && children} diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..d812306 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -31,7 +31,7 @@ export function DataTable>({ data, columns }: // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir((prev) => (prev === "asc" ? "desc" : "asc")) } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..526c0ef 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -12,9 +12,7 @@ export function formatDate(date: Date): string { // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY return new Intl.DateTimeFormat("en-AU", { - month: "numeric", - day: "numeric", - year: "numeric", + dateStyle: "short", }).format(date) } diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]