From 8ae3264e2ff7a4dfe4dc53e2851a67086798de27 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Thu, 18 Jun 2026 03:20:46 +0000
Subject: [PATCH] fix: resolve cross-package test failures and type error

- api.ts: import renamed hook useDebounce (was useThrottle) from @e2e/utils
- Button: forward aria-label so icon-only buttons have an accessible name
- DataTable: fix stale-closure bug caught by controlled re-render test
- date.ts: use en-AU locale ordering (day-first) instead of US field order
- tsconfig: add bun-types so bun:test test files type-check cleanly
---
 apps/web/src/lib/api.ts                       |  5 ++---
 packages/ui/src/components/Button/Button.tsx  |  7 ++++--
 .../ui/src/components/DataTable/DataTable.tsx |  2 +-
 packages/utils/src/format/date.ts             | 22 +++++++++----------
 tsconfig.json                                 |  1 +
 5 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..e9e0a52 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -7,8 +7,7 @@
  * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -29,4 +28,4 @@ export async function fetchPosts() {
 export { formatDate, formatAUD }
 
 // Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..9ae324a 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -34,13 +34,16 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (iconOnly && !ariaLabel) {
+    console.warn("Button: icon-only buttons require an aria-label for accessibility (WCAG 4.1.2)")
+  }
+  const resolvedAriaLabel = ariaLabel ?? (iconOnly ? "" : undefined)
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..d812306 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -31,7 +31,7 @@ export function DataTable<T extends Record<string, unknown>>({ data, columns }:
   // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..ae6dff0 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,21 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Uses formatToParts with explicit numeric fields and the en-AU locale so
+ * that Intl supplies Australian field ordering (day/month/year) and the
+ * locale's own separators. The day part is rendered without a leading zero
+ * (matching en-AU convention) while the year is always 4 digits.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  const formatter = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "numeric",
     year: "numeric",
-  }).format(date)
+  })
+  return formatter
+    .formatToParts(date)
+    .map((p) => (p.type === "day" ? String(parseInt(p.value, 10)) : p.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]