Implement JSON output for external consumers and update workflow#2079
Open
marco-s wants to merge 2 commits into
Open
Implement JSON output for external consumers and update workflow#2079marco-s wants to merge 2 commits into
marco-s wants to merge 2 commits into
Conversation
Added functionality to write a JSON bundle for external consumers, including schema version and generation timestamp.
✅ Deploy Preview for pytorch-dot-org-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fffrog
reviewed
Jun 9, 2026
| write_output(js_content) | ||
|
|
||
| # Also write the JSON file for the external consumer | ||
| write_platforms_json(platform_data, markdown_content, str(BASE_DIR / JSON_OUT_PATH)) |
There was a problem hiding this comment.
Hi @marco-s, would you mind saving this file to the Asset directory instead? I believe the correct path should be ASSETS_DIR/JSON_OUT_PATH, right? :D
|
Hi @marco-s , thank you for updats, it look good to me. Parsing a Json is very easy compared to parsing a js file :D |
|
Hi @albanD, would you mind helping to review this PR, thank you in advance. Why we need those changesThe JSON is easier to parse than JS file from WP side, so we need to save the output into JSON and release it in the master branch for website. |
Contributor
|
Thanks for fixing the CI error @marco-s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the
gen_additional_platforms.pyscript to generate a new JSON bundle for external consumers. And, it updates the workflow to install required Python dependencies, adds automated error reporting and pull request creation.Motivation
Make it easier for external consumers to get the additional platforms matrix information. This PR adds to #2072.