From 814961dba19c4ea86a6720ba09ba232461bd1612 Mon Sep 17 00:00:00 2001 From: Avasam Date: Tue, 3 Nov 2026 10:14:07 -0500 Subject: [PATCH] Add CODEOWNERS and update maintainer guidelines --- .github/CODEOWNERS | 11 +++++++++++ .vscode/extensions.json | 1 + docs/maintainer-guide.md | 14 ++++++++++++++ 3 files changed, 26 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000000..90470f26d335 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,11 @@ +# See docs/maintainer-guide.md#subscribing-to-changes-with-codeowners +# Last matching pattern wins: list all subscribers to a path on one line. + +/stdlib/distutils/ @Avasam + +/stubs/keyboard/ @Avasam +/stubs/PyAutoGUI/ @Avasam +/stubs/pyinstaller/ @Avasam +/stubs/python-xlib/ @Avasam +/stubs/pywin32/ @Avasam +/stubs/setuptools/ @Avasam diff --git a/.vscode/extensions.json b/.vscode/extensions.json index 01b9ad4369db..b5885d03d0a1 100644 --- a/.vscode/extensions.json +++ b/.vscode/extensions.json @@ -5,6 +5,7 @@ "bierner.github-markdown-preview", "charliermarsh.ruff", "editorconfig.editorconfig", + "jasonnutter.vscode-codeowners", "ms-python.black-formatter", "ms-python.flake8", "ms-python.mypy-type-checker", diff --git a/docs/maintainer-guide.md b/docs/maintainer-guide.md index 3910c930e657..6037695a8a4d 100644 --- a/docs/maintainer-guide.md +++ b/docs/maintainer-guide.md @@ -40,6 +40,20 @@ When merging pull requests, follow these guidelines: and assume that the reader has no access to the diff. * Delete branches for merged PRs (by maintainers pushing to the main repo). +## Subscribing to Changes with CODEOWNERS + +The [`.github/CODEOWNERS`](../.github/CODEOWNERS) file lets Contributors and Maintainers subscribe to changes to specific stubs. GitHub automatically requests a review from everyone listed for the paths a pull request touches. + +Despite its name, this file is not about who "owns" the code. Being listed is only a way to get notified. It grants no extra permissions, and a review from a listed person is not required to merge a PR. + +Maintainers can freely add and remove themselves. + +Trusted contributors who are actively involved with specific stubs (for example, the original author of those stubs) may request to be added by opening a PR that edits the file. This is limited to trusted and involved contributors, so that maintainers don't have to constantly edit the file. By requesting to be added, a contributor acknowledges that: + +* They will be requested as a reviewer on every PR touching those stubs. +* Maintainers will not necessarily wait for their review before merging. +* Requests to be removed from the file also go through a PR, and may take some time to be merged. + ## Marking PRs as "deferred" *See also the [guidelines in the CONTRIBUTING file](../CONTRIBUTING.md#marking-prs-as-deferred).*