Commit b23159e
committed
gh-89696: Fix loop.sock_connect docs on address resolution
The docs claimed unconditionally that the address no longer needs to be
resolved, but only SelectorEventLoop does that. ProactorEventLoop, the
default event loop on Windows, passes the address straight to ConnectEx()
and WSAConnect(), which parse it with WSAStringToAddress() and therefore
only accept numeric addresses.1 parent adebb68 commit b23159e
1 file changed
Lines changed: 14 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1145 | 1145 | | |
1146 | 1146 | | |
1147 | 1147 | | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
| 1151 | + | |
| 1152 | + | |
| 1153 | + | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
1148 | 1160 | | |
1149 | | - | |
1150 | | - | |
1151 | | - | |
1152 | | - | |
1153 | | - | |
| 1161 | + | |
| 1162 | + | |
1154 | 1163 | | |
1155 | 1164 | | |
1156 | 1165 | | |
| |||
0 commit comments