Skip to content

Inconsistent solar zenith parameter naming in decomposition functions #2851

Description

@ramaroesilva

Describe the bug
Among the decomposition models, solar zenith assumes two parameter names depending on the function:

  • zenith (erbs, erbs_driesse, orgill_hollands, campbell_norman, dirindex )
  • solar_zenith (louche, disc, dirint, boland).

This demands adjustments in the code when a user wants to run different decomposition models for comparison.

Expected behavior
Assume a harmonized parameter naming across all functions, solar_zenith seems good to me :-)

Additional context
Relates to #1403. Can be a good issue for first-timers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions