From ae2b84fa0078eca0a8691fe5eaf68fdeb85e296d Mon Sep 17 00:00:00 2001
From: Jay DeLuca <jaydeluca4@gmail.com>
Date: Wed, 27 May 2026 14:18:49 -0400
Subject: [PATCH] chore: move narrowly-used test deps out of root pom
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

junit-pioneer, awaitility, wiremock, and guava (test scope) were
declared in the root pom.xml, adding them to the classpath of all
24 core modules. Each is only needed by 1–3 modules:

- junit-pioneer: prometheus-metrics-config (SetSystemProperty)
- awaitility: prometheus-metrics-core + prometheus-metrics-exporter-opentelemetry
- wiremock: prometheus-metrics-exporter-opentelemetry (ExemplarTest)
- guava: prometheus-metrics-core, prometheus-metrics-exporter-opentelemetry,
  integration-tests/it-exporter/it-exporter-test

Add version properties for junit-pioneer, awaitility, and wiremock
to the root pom (guava.version already existed). Remove the four
deps from root <dependencies> and add them only in the modules that
actually use them. The shaded opentelemetry module also receives
the same test deps since it copies and compiles the same test sources.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
---
 .../it-exporter/it-exporter-test/pom.xml      |  6 ++++
 pom.xml                                       | 33 ++-----------------
 prometheus-metrics-config/pom.xml             |  9 +++++
 prometheus-metrics-core/pom.xml               | 12 +++++++
 .../pom.xml                                   | 24 ++++++++++++++
 .../pom.xml                                   | 24 ++++++++++++++
 6 files changed, 78 insertions(+), 30 deletions(-)

diff --git a/integration-tests/it-exporter/it-exporter-test/pom.xml b/integration-tests/it-exporter/it-exporter-test/pom.xml
index 9b221feb4..b9c368dc9 100644
--- a/integration-tests/it-exporter/it-exporter-test/pom.xml
+++ b/integration-tests/it-exporter/it-exporter-test/pom.xml
@@ -23,5 +23,11 @@
       <version>${project.version}</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>${guava.version}</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 </project>
diff --git a/pom.xml b/pom.xml
index ba74f7560..d6aae38f2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -22,6 +22,9 @@
     <automatic.module.name>--module-name-need-to-be-overridden--</automatic.module.name>
     <protobuf-java.version>4.35.0</protobuf-java.version>
     <guava.version>33.6.0-jre</guava.version>
+    <junit-pioneer.version>2.3.0</junit-pioneer.version>
+    <awaitility.version>4.3.0</awaitility.version>
+    <wiremock.version>3.13.2</wiremock.version>
     <junit-jupiter.version>6.0.3</junit-jupiter.version>
     <otel.instrumentation.version>2.28.1-alpha</otel.instrumentation.version>
     <java.version>8</java.version>
@@ -92,42 +95,12 @@
       <version>3.27.7</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>com.google.guava</groupId>
-      <artifactId>guava</artifactId>
-      <version>${guava.version}</version>
-      <scope>test</scope>
-    </dependency>
     <dependency>
       <groupId>org.slf4j</groupId>
       <artifactId>slf4j-simple</artifactId>
       <version>2.0.18</version>
       <scope>test</scope>
     </dependency>
-    <dependency>
-      <groupId>org.junit-pioneer</groupId>
-      <artifactId>junit-pioneer</artifactId>
-      <version>2.3.0</version>
-      <scope>test</scope>
-    </dependency>
-    <dependency>
-      <groupId>org.awaitility</groupId>
-      <artifactId>awaitility</artifactId>
-      <version>4.3.0</version>
-      <scope>test</scope>
-    </dependency>
-    <dependency>
-      <groupId>org.wiremock</groupId>
-      <artifactId>wiremock</artifactId>
-      <version>3.13.2</version>
-      <scope>test</scope>
-      <exclusions>
-        <exclusion>
-          <groupId>org.hamcrest</groupId>
-          <artifactId>hamcrest-core</artifactId>
-        </exclusion>
-      </exclusions>
-    </dependency>
   </dependencies>
 
   <build>
diff --git a/prometheus-metrics-config/pom.xml b/prometheus-metrics-config/pom.xml
index 9a2b01c88..d505248e7 100644
--- a/prometheus-metrics-config/pom.xml
+++ b/prometheus-metrics-config/pom.xml
@@ -20,4 +20,13 @@
     <automatic.module.name>io.prometheus.metrics.config</automatic.module.name>
   </properties>
 
+  <dependencies>
+    <dependency>
+      <groupId>org.junit-pioneer</groupId>
+      <artifactId>junit-pioneer</artifactId>
+      <version>${junit-pioneer.version}</version>
+      <scope>test</scope>
+    </dependency>
+  </dependencies>
+
 </project>
diff --git a/prometheus-metrics-core/pom.xml b/prometheus-metrics-core/pom.xml
index d7e9e17b4..3ba812f1d 100644
--- a/prometheus-metrics-core/pom.xml
+++ b/prometheus-metrics-core/pom.xml
@@ -50,5 +50,17 @@
       <version>3.6.1</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.awaitility</groupId>
+      <artifactId>awaitility</artifactId>
+      <version>${awaitility.version}</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>${guava.version}</version>
+      <scope>test</scope>
+    </dependency>
   </dependencies>
 </project>
diff --git a/prometheus-metrics-exporter-opentelemetry-shaded/pom.xml b/prometheus-metrics-exporter-opentelemetry-shaded/pom.xml
index 93a5c6200..308ee761e 100644
--- a/prometheus-metrics-exporter-opentelemetry-shaded/pom.xml
+++ b/prometheus-metrics-exporter-opentelemetry-shaded/pom.xml
@@ -94,6 +94,30 @@
           <artifactId>opentelemetry-sdk-testing</artifactId>
           <scope>test</scope>
         </dependency>
+        <dependency>
+          <groupId>org.wiremock</groupId>
+          <artifactId>wiremock</artifactId>
+          <version>${wiremock.version}</version>
+          <scope>test</scope>
+          <exclusions>
+            <exclusion>
+              <groupId>org.hamcrest</groupId>
+              <artifactId>hamcrest-core</artifactId>
+            </exclusion>
+          </exclusions>
+        </dependency>
+        <dependency>
+          <groupId>org.awaitility</groupId>
+          <artifactId>awaitility</artifactId>
+          <version>${awaitility.version}</version>
+          <scope>test</scope>
+        </dependency>
+        <dependency>
+          <groupId>com.google.guava</groupId>
+          <artifactId>guava</artifactId>
+          <version>${guava.version}</version>
+          <scope>test</scope>
+        </dependency>
       </dependencies>
     </profile>
   </profiles>
diff --git a/prometheus-metrics-exporter-opentelemetry/pom.xml b/prometheus-metrics-exporter-opentelemetry/pom.xml
index e4aa7fa2f..415882bb4 100644
--- a/prometheus-metrics-exporter-opentelemetry/pom.xml
+++ b/prometheus-metrics-exporter-opentelemetry/pom.xml
@@ -95,6 +95,30 @@
           <artifactId>opentelemetry-sdk-testing</artifactId>
           <scope>test</scope>
         </dependency>
+        <dependency>
+          <groupId>org.wiremock</groupId>
+          <artifactId>wiremock</artifactId>
+          <version>${wiremock.version}</version>
+          <scope>test</scope>
+          <exclusions>
+            <exclusion>
+              <groupId>org.hamcrest</groupId>
+              <artifactId>hamcrest-core</artifactId>
+            </exclusion>
+          </exclusions>
+        </dependency>
+        <dependency>
+          <groupId>org.awaitility</groupId>
+          <artifactId>awaitility</artifactId>
+          <version>${awaitility.version}</version>
+          <scope>test</scope>
+        </dependency>
+        <dependency>
+          <groupId>com.google.guava</groupId>
+          <artifactId>guava</artifactId>
+          <version>${guava.version}</version>
+          <scope>test</scope>
+        </dependency>
       </dependencies>
     </profile>
   </profiles>