suppress cppcheck mismatchingContainerExpression instead of rewriting

Keep the terse erase-remove one-liners from the ranges migration (#244)
and silence cppcheck's mismatchingContainerExpression false positive
instead. The warning fires because a range algorithm returns a subrange,
so the first iterator's source expression (ranges::unique(x)) differs
syntactically from the second (end(x)) even though end(subrange) is
end(x) by construction.

Reverts the earlier local-variable rewrite and adds line-anchored
suppressions for the six affected call sites.

Author: cameroncuster

library/trees/extra_members/virtual_tree.hpp

@@ -16,8 +16,7 @@ array<vi, 2> compress_tree(vi subset) {
   rep(i, 1, len)
     subset.push_back(lca(subset[i - 1], subset[i]));
   ranges::sort(subset, {}, proj);
-  auto dup = ranges::unique(subset);
-  subset.erase(begin(dup), end(dup));
+  subset.erase(begin(ranges::unique(subset)), end(subset));
   return {
     mono_st(subset,
       [&](int u, int v) { return in_subtree(u, v); }),

tests/.config/.cppcheck_suppression_list

@@ -62,3 +62,9 @@ unusedFunction:../kactl/stress-tests/utilities/genTree.h:49
 containerOutOfBounds:../library/data_structures_[l,r)/uncommon/permutation_tree.hpp:85
 ctuOneDefinitionRuleViolation:../library/data_structures_[l,r)/bit.hpp:12
 ctuOneDefinitionRuleViolation:../library/data_structures_[l,r)/lazy_seg_tree.hpp:4
+mismatchingContainerExpression:../library/trees/extra_members/virtual_tree.hpp:19
+mismatchingContainerExpression:library_checker_aizu_tests/data_structures/bit_ordered_set.test.cpp:20
+mismatchingContainerExpression:library_checker_aizu_tests/data_structures/kth_smallest_pst.test.cpp:13
+mismatchingContainerExpression:library_checker_aizu_tests/data_structures/mode_query.test.cpp:13
+mismatchingContainerExpression:library_checker_aizu_tests/strings/sa_sort_pairs.test.cpp:13
+mismatchingContainerExpression:library_checker_aizu_tests/strings/single_matching_bs.test.cpp:73

tests/library_checker_aizu_tests/data_structures/bit_ordered_set.test.cpp

@@ -17,8 +17,8 @@ int main() {
     compress.push_back(x);
   }
   ranges::sort(compress);
-  auto dup = ranges::unique(compress);
-  compress.erase(begin(dup), end(dup));
+  compress.erase(begin(ranges::unique(compress)),
+    end(compress));
   BIT bit(sz(compress));
   auto get_compressed_idx = [&](int val) -> int {
     int l = 0, r = sz(compress);

tests/library_checker_aizu_tests/data_structures/kth_smallest_pst.test.cpp

@@ -10,8 +10,7 @@ int main() {
   rep(i, 0, n) cin >> arr[i];
   vi sorted(arr);
   ranges::sort(sorted);
-  auto dup = ranges::unique(sorted);
-  sorted.erase(begin(dup), end(dup));
+  sorted.erase(begin(ranges::unique(sorted)), end(sorted));
   for (int& val : arr) {
     int start = 0, end = sz(sorted);
     while (start + 1 < end) {

tests/library_checker_aizu_tests/data_structures/mode_query.test.cpp

@@ -10,8 +10,7 @@ int main() {
   rep(i, 0, n) cin >> a[i];
   vi comp(a);
   ranges::sort(comp);
-  auto dup = ranges::unique(comp);
-  comp.erase(begin(dup), end(dup));
+  comp.erase(begin(ranges::unique(comp)), end(comp));
   for (int& val : a) {
     int start = 0, end = sz(comp);
     while (start + 1 < end) {

tests/library_checker_aizu_tests/strings/sa_sort_pairs.test.cpp

@@ -10,8 +10,8 @@ int main() {
   for (int& x : arr) cin >> x;
   vi compress(arr);
   ranges::sort(compress);
-  auto dup = ranges::unique(compress);
-  compress.erase(begin(dup), end(dup));
+  compress.erase(begin(ranges::unique(compress)),
+    end(compress));
   for (int& x : arr) {
     int l = -1, r = int(sz(compress));
     while (r - l > 1) {

tests/library_checker_aizu_tests/strings/single_matching_bs.test.cpp

@@ -69,9 +69,10 @@ int main() {
       assert(sa_ri2 - sa_le2 == 1 + sa_ri - sa_le);
       vi matches_other(begin(lq_both.sa) + sa_le2,
         begin(lq_both.sa) + sa_ri2);
-      auto rem = ranges::remove_if(matches_other,
-        [&](int val) { return val >= sz(s) + 1; });
-      matches_other.erase(begin(rem), end(rem));
+      matches_other.erase(
+        begin(ranges::remove_if(matches_other,
+          [&](int val) { return val >= sz(s) + 1; })),
+        end(matches_other));
       ranges::sort(matches_other);
       assert(matches == matches_other);
     }