.NET Core Support?

[DBCI]

Hello Pascal :)

I hate to be a pest, but do you think there's any chance for .NET Core support for this?

Thank you for the time and effort!
DB

[picrap]

Well... That was not planned at all 😄
StitcherBoy is used to created build tools, and don't understand why build tools would need to work with .NET Core (but there are a lot of things I don't understand...).
Regarding .NET Core, I am waiting for .NET Standard 2.0 which will be supported by .NET Core. So for me, a more efficient move (if I make it) is to move to .NET Standard.

[DBCI]

Currently, if I try to add (as a NuGet package) either MrAdvice or StitcherBoy to a .NET Core application, the action fails.

Perhaps all that's needed is re-packaging of the tools in a way that would support a DNC project but I don't know if that's even possible.

The one thing I cannot do is wait... but that's my problem. ;)

[picrap]

MrAdvice can run as a command-line application (this is totally undocumented, but was very helpful to debug it). However, you'll need to do some plumbing by yourself, such as setting the post-build step and parameters.
The parameters are the same as the MSTask, so this will look like MrAdvice.Weaver AssemblyPath=... References=...

[DBCI]

OK, that sounds like a good start! 😄 but... correct me if I'm wrong here, wouldn't I still need to reference the MrAdvice DLL to create my advices, pointcuts etc from within my DNC source code? 😨

[picrap]

Yes, you need the reference to MrAdvice.dll, but this can also be made manually (by downloading the package from nuget, extracting it, and referencing the right dll).
That's the poor man's solution, but probably better that nothing...

[DBCI]

I'm going to try this and hopefully get out of your hair... 😃

[DBCI]

OK, so here's an update:

I managed to activate the MrAdvice Weaver Task properly on my DNC project! 😄 That's the good news because StitcherBoy doesn't require changes. However... I ran into exactly the same problem as I did with MrAdvice, i.e. MrAdvice.Weaver couldn't properly load the MrAdvice DLL!

Is it possible that it's not working because @(ReferencePath) and @(ReferenceCopyLocalPaths) are coming up empty?? 😨

[DBCI]

Another quick update... I passed MrAdvice.dll in the ReferencePath parameter and it looks like the Weaver has done it's job... that's the good news. The bad news is that the project doesn't run, but I'll report this as a MrAdvice issue.

I think you can close this issue if you'd like...

[AlexanderButs]

Hey, Pascal.

Is still necessary to do to migrate MrAdvice to .NET Core? What do you think?

I've done some work by migrating StitcherBoy to netstandard2.0 here https://github.com/AlexanderButs/StitcherBoy and loaded this package as a nuget into MrAdvice as a netstandard2.0 dependancy. Could you have a look on my changes and maybe i'll send a PR? (But you will need to do some work related to nuget release).

Also we can discuss further work to do to migrate MrAdvice to .NET Core - as I understand I need to migrate Blobber as well to be able to pack MrAdvice into one package. Am I right?

Alex.

[picrap]

Hi Alexander, I understand the lot of forks you made recently 😉

How would consider the final Mr Advice for .NET Core? Can it run as a build task? How otherwise? Once we agree on where we need to go, we'll try to see how to go there.

[AlexanderButs]

Yeah, we are in .NET Core transition state and I have some time to help you with this library so why not :)

Idea is the next - MrAdvice will work the same as it does right now. Everything I need to do is to migrate actual MrAdvice.dll to support net461 and netstandard2.0, make MrAdvice.Weaver.exe compatible with net461 and netstandard2.0 (put these to two separate folders) and use proper weaver inside msbuild task depending on framework target you are building to. For all that stuff we need to migrate StitcherBoy and Blobber as well as I understand. StitcherBoy is almost done by me - need to test a little bit on your side and release to nuget. Your thoughts? :)

[picrap]

How about the references to Microsoft.Build assemblies? Are they still available?

[AlexanderButs]

Yes, they are. You can look inside my fork how they are used for different target frameworks. I use conditional reference there.

[picrap]

OK, so I guess moving to .NET Standard is the smart thing to do :) I'm currently reviewing your changes