Skip to content

Rust codebase has drifted from cargo fmt/clippy conventions (~1152 diff hunks, 98 warnings), not CI-enforced #2096

Description

@carlos-alm

While sweeping PR #2043 (fix(lua): port eval/computed-key dynamic-call detection to WASM extractor) as part of a PR-merge session, found that running `cargo fmt` against the current `crates/codegraph-core` produces roughly 1152 diff hunks, and `cargo clippy` reports 98 warnings. Neither `cargo fmt --check` nor `cargo clippy` currently run in CI, so this drift has accumulated silently and isn't blocking anything today.

Confirmed unrelated to PR #2043's own changes (the drift pre-dates that PR and spans the whole crate, not just the files it touched).

Suggested follow-up (not investigated in depth — flagging for triage):

  • Decide whether to adopt `cargo fmt --check` and/or `cargo clippy` as CI gates (matching the existing `Lint`/Biome enforcement on the TS side).
  • If adopted, a one-time repo-wide `cargo fmt` pass (and clippy warning triage) would be needed first to avoid a wall of unrelated diff noise on the PR that turns the gate on.

Filed per this repo's scope-discipline convention — out of scope for PR #2043 itself, but a real gap in Rust code-quality enforcement that shouldn't go untracked.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions