From dd44f0f10064421100210b230d8aa29188818f4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20M=C3=A9sz=C3=A1ros?= Date: Wed, 29 Jul 2026 18:23:34 +0200 Subject: [PATCH] fix: remove dangling placeholder from event source close warning `log.warn("Error closing {} -> {}", eventSource.name(), e)` supplies two placeholders but only one non-throwable argument. SLF4J trims a trailing `Throwable` and reports it as the exception, so the stack trace is logged correctly, but the second placeholder is left unfilled and the message renders with a literal brace pair: Error closing myEventSource -> {} Drops the redundant placeholder and names what is being logged. Note: the superficially similar calls in `InformerManager.stop` and `InformerWrapper.start` are correct as they stand - they pass more non-throwable arguments than placeholders, so nothing is left dangling. --- .../operator/processing/event/EventSourceManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java index 441d3cf178..9419ebde9a 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java @@ -143,7 +143,7 @@ private Void stopEventSource(EventSource eventSource) { eventSource.stop(); logEventSourceEvent(eventSource, "Stopped"); } catch (Exception e) { - log.warn("Error closing {} -> {}", eventSource.name(), e); + log.warn("Error closing event source {}", eventSource.name(), e); } return null; }