From 4c1d62b75f2d2ca3a1c72cd7be346cf063776729 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Fri, 20 Nov 2026 01:31:48 -0500 Subject: [PATCH 1/3] Apply suggested fix to web/tests/e2e/hlsRecovery.browser.spec.js from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --- web/tests/e2e/hlsRecovery.browser.spec.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/web/tests/e2e/hlsRecovery.browser.spec.js b/web/tests/e2e/hlsRecovery.browser.spec.js index d1e7b83b7..51c686b9f 100644 --- a/web/tests/e2e/hlsRecovery.browser.spec.js +++ b/web/tests/e2e/hlsRecovery.browser.spec.js @@ -298,3 +298,16 @@ it('force-native preference bypasses go2rtc settings and uses native recovery',a expect(await page.evaluate(()=>window.errors)).toEqual([]); } finally {await browser.close();} }); + +it('force-native uses native playback even when hls.js support is available',async()=>{ + const {browser,page}=await openPlayer({enabled:true,forceNative:true,nativePlayer:false}); + try { + const nativeManifest='/hls/fixture%20camera/index.m3u8'; + await page.waitForFunction(url=>window.requests.some(r=>r.url===url)&& + window.nativeSources.includes(url),nativeManifest); + expect(await page.evaluate(()=>window.requests.length>0&& + window.requests.every(r=>r.url==='/hls/fixture%20camera/index.m3u8'))).toBe(true); + expect(await page.evaluate(()=>window.players.length)).toBe(0); + expect(await page.evaluate(()=>window.settingsReads.includes('enabled'))).toBe(false); + } finally {await browser.close();} +}); From ad9cc893d85b613469817f518b5286b4c57e4686 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Fri, 20 Nov 2026 01:31:49 -0500 Subject: [PATCH 2/3] Apply suggested fix to web/tests/e2e/hlsRecovery.browser.spec.js from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --- web/tests/e2e/hlsRecovery.browser.spec.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/web/tests/e2e/hlsRecovery.browser.spec.js b/web/tests/e2e/hlsRecovery.browser.spec.js index 51c686b9f..a8bbe37dd 100644 --- a/web/tests/e2e/hlsRecovery.browser.spec.js +++ b/web/tests/e2e/hlsRecovery.browser.spec.js @@ -204,12 +204,15 @@ it('resets fallback transport when the tile receives a different stream',async() } finally {await browser.close();} }); -it.each(['exhausted','unrecoverable','native'])( +it.each(['exhausted','networkExhausted','unrecoverable','native'])( '%s recovery falls back when go2rtc was only auto-detected',async branch=>{ const {browser,page}=await openPlayer({enabled:false,nativePlayer:branch==='native'}); try { if(branch==='native') await page.locator('video').dispatchEvent('error'); - else await page.evaluate(value=>window.emitFatal(value==='exhausted'?'media':'other',value==='exhausted'?4:1),branch); + else await page.evaluate(value=>window.emitFatal( + value==='exhausted'?'media':value==='networkExhausted'?'network':'other', + value==='exhausted'||value==='networkExhausted'?4:1, + ),branch); expect(await page.evaluate(()=>window.errors)).toEqual([]); await page.waitForFunction(currentBranch=>{ const fallbackUrl='/hls/fixture%20camera/index.m3u8'; From 71b78bd157db830576457d3a4c61d01220c79fb2 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Fri, 20 Nov 2026 01:39:23 -0500 Subject: [PATCH 3/3] Test forced native source with both playback engines --- web/tests/e2e/hlsRecovery.browser.spec.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/tests/e2e/hlsRecovery.browser.spec.js b/web/tests/e2e/hlsRecovery.browser.spec.js index a8bbe37dd..a471c261a 100644 --- a/web/tests/e2e/hlsRecovery.browser.spec.js +++ b/web/tests/e2e/hlsRecovery.browser.spec.js @@ -302,15 +302,15 @@ it('force-native preference bypasses go2rtc settings and uses native recovery',a } finally {await browser.close();} }); -it('force-native uses native playback even when hls.js support is available',async()=>{ +it('force-native selects the lightNVR manifest when hls.js is available',async()=>{ const {browser,page}=await openPlayer({enabled:true,forceNative:true,nativePlayer:false}); try { const nativeManifest='/hls/fixture%20camera/index.m3u8'; await page.waitForFunction(url=>window.requests.some(r=>r.url===url)&& - window.nativeSources.includes(url),nativeManifest); + window.players.some(p=>!p.destroyed&&p.sources.includes(url)),nativeManifest); expect(await page.evaluate(()=>window.requests.length>0&& window.requests.every(r=>r.url==='/hls/fixture%20camera/index.m3u8'))).toBe(true); - expect(await page.evaluate(()=>window.players.length)).toBe(0); + expect(await page.evaluate(()=>window.nativeSources.length)).toBe(0); expect(await page.evaluate(()=>window.settingsReads.includes('enabled'))).toBe(false); } finally {await browser.close();} });