From b494418abeec3f2f3b01ca9a1cfd774a23d1a634 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Fri, 20 Nov 2026 01:31:35 -0500 Subject: [PATCH 1/2] Apply suggested fix to web/js/components/preact/HLSVideoCell.tsx from Copilot Autofix Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> --- web/js/components/preact/HLSVideoCell.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/js/components/preact/HLSVideoCell.tsx b/web/js/components/preact/HLSVideoCell.tsx index 0cbaea3c0..652367b2c 100644 --- a/web/js/components/preact/HLSVideoCell.tsx +++ b/web/js/components/preact/HLSVideoCell.tsx @@ -96,7 +96,7 @@ export function HLSVideoCell({ useEffect(() => { setPrivacyActive(!!stream.privacy_mode); - }, [stream.privacy_mode]); + }, [streamId, stream.privacy_mode]); // HLS source state: 'go2rtc' (go2rtc's dynamic HLS), 'native' (lightNVR FFmpeg-based HLS), or 'failed' // Default to native lightNVR HLS (reliable, always running when streaming enabled) From b036e551d04d71d878e62fd3117c410b79f27849 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Fri, 20 Nov 2026 01:39:17 -0500 Subject: [PATCH 2/2] Test privacy reset when HLS tile changes streams --- web/tests/e2e/hlsRecovery.browser.spec.js | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/web/tests/e2e/hlsRecovery.browser.spec.js b/web/tests/e2e/hlsRecovery.browser.spec.js index d1e7b83b7..727485214 100644 --- a/web/tests/e2e/hlsRecovery.browser.spec.js +++ b/web/tests/e2e/hlsRecovery.browser.spec.js @@ -188,6 +188,23 @@ it('ignores an old privacy response after the tile changes streams',async()=>{ } finally {await browser.close();} }); +it('resets local privacy state when a different stream has the same server flag',async()=>{ + const {browser,page}=await openPlayer({enabled:true,showControls:true}); + try { + await page.locator('button[aria-label="live.pauseForPrivacy"]').click(); + await page.locator('.btn-primary').click(); + await page.locator('button[aria-label="live.resumeStream"]').waitFor({state:'visible'}); + await page.evaluate(()=>{ + window.config.streamName='second camera'; + window.config.streamId='second'; + window.mount(); + }); + await page.locator('button[aria-label="live.resumeStream"]').waitFor({state:'detached'}); + expect(await page.evaluate(()=>document.querySelector('.video-cell')?.dataset.streamName)).toBe('second camera'); + expect(await page.evaluate(()=>window.errors)).toEqual([]); + } finally {await browser.close();} +}); + it('resets fallback transport when the tile receives a different stream',async()=>{ const {browser,page}=await openPlayer({enabled:false}); try {