Skip to content

Commit ed5bf34

Browse files
committed
Run check in CI's build job
The build job ran ./gradlew test, and forbidden-apis hangs off check, so the previous commit's ban would never have failed a pull request. check also runs Checkstyle and the Gradle plugin's validatePlugins, which pass. The jdk jobs, which run the same code on other JDKs, keep running only the tests. The README and CLAUDE.md say what CI runs.
1 parent 40df976 commit ed5bf34

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
caches/*/transforms
5252
5353
- name: Build
54-
run: ./gradlew test
54+
run: ./gradlew check
5555

5656
- name: Publish Test Report
5757
uses: mikepenz/action-junit-report@4a26df3e2ae132254ba12a53f65a388d0961e786 # v6.7.0

‎CLAUDE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Working in this repository
22

33
Building and testing: the README's "Building and testing locally" section. Gradle runs on the Temurin 21 that
4-
`mise install` provides, `./gradlew test` is what CI runs, and `./gradlew formatDiff` formats the files you changed.
4+
`mise install` provides, `./gradlew check` is what CI runs, and `./gradlew formatDiff` formats the files you changed.
55

66
## Conventions for new code
77

‎README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ fixes made the output differ from upstream, that numbering lost its meaning.
134134

135135
```bash
136136
mise trust && mise install
137-
./gradlew test # what the CI build job runs
137+
./gradlew check # what the CI build job runs: the tests, Checkstyle and forbidden-apis
138138
```
139139

140140
`-PjavaRuntime=25` runs the same tests on JDK 25, as CI's `jdk` jobs do for 25, 26 and 27, and for

0 commit comments

Comments
 (0)