Commit e89a83a
committed
Check who opened the pull request before auto-merging it
The Dependabot auto-merge job ran when github.actor was
dependabot[bot]. zizmor (bot-conditions) flags that as spoofable: the
actor is whoever caused the event, so a run Dependabot triggers on a
pull request someone else opened passes the check, and the job then
approves the pull request and enables auto-merge.
The job now checks github.event.pull_request.user.login, the author of
the pull request, which is the condition GitHub's own documentation
for Dependabot auto-merge uses. dependabot/fetch-metadata still checks
the author and that the commits are Dependabot's before anything is
approved.1 parent a5b690e commit e89a83a
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
0 commit comments