Accept an annotated C-style array dimension on a parameter

A method parameter declared as "int a @anno []" crashed the formatter
with a VerifyException from visitAnnotatedArrayType: the parameter's
type was printed as a whole, dimensions included, before the name, and
the annotated dimension that belongs after the name had nowhere to go.
Fields and locals were fine, because their path already splits the
dimensions off the type; parameters, resources and catch parameters go
through visitToDeclare, which did not.

This ports the fix for google/google-java-format#374, upstream commit
ed40e472 by cushon, together with the null check that
google/google-java-format#463 (upstream commit e19b7637) added next to
it: a "var" declaration or an untyped lambda parameter has no type
tree to split. The golden I374 comes from upstream, with the expected
output in this project's style.

The 15,747 files of the JDK 21 sources format exactly as before.

Author: cushon

open-java-format/src/main/java/com/palantir/javaformat/java/JavaInputAstVisitor.java

@@ -2669,18 +2669,29 @@ private void visitToDeclare(
             Optional<String> trailing,
             Optional<BreakTag> annotationBreakForRecords) {
         sync(node);
+        Optional<TypeWithDims> typeWithDims;
+        Tree type;
+        if (node.getType() != null) {
+            TypeWithDims extractedDims = DimensionHelpers.extractDims(node.getType(), SortedDims.YES);
+            typeWithDims = Optional.of(extractedDims);
+            type = extractedDims.node;
+        } else {
+            // "var" and an untyped lambda parameter have no type tree
+            typeWithDims = Optional.empty();
+            type = null;
+        }
         declareOne(
                 kind,
                 annotationsDirection,
                 Optional.of(node.getModifiers()),
-                node.getType(),
+                type,
                 node.getName(),
                 "",
                 equals,
                 initializer,
                 trailing,
                 /* receiverExpression= */ Optional.empty(),
-                /* typeWithDims= */ Optional.empty(),
+                typeWithDims,
                 annotationBreakForRecords);
     }
 

open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I374.input

@@ -0,0 +1,9 @@
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Target;
+
+@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})
+@interface MyTypeAnno {}
+
+public class GjfFailure {
+  void m(int a @MyTypeAnno []) {}
+}

open-java-format/src/test/resources/com/palantir/javaformat/java/testdata/I374.output

@@ -0,0 +1,9 @@
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Target;
+
+@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER})
+@interface MyTypeAnno {}
+
+public class GjfFailure {
+    void m(int a @MyTypeAnno []) {}
+}