From 34602351e8dbfa495313ea8d88e423148f19b34d Mon Sep 17 00:00:00 2001 From: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com> Date: Thu, 10 Sep 2026 03:18:13 +0100 Subject: [PATCH 1/2] fix(querystring): preserve empty string values --- src/openai/_qs.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/openai/_qs.py b/src/openai/_qs.py index 4127c19c62..d3c34ce6b0 100644 --- a/src/openai/_qs.py +++ b/src/openai/_qs.py @@ -112,10 +112,9 @@ def _stringify_item( f"Unknown array_format value: {array_format}, choose from {', '.join(get_args(ArrayFormat))}" ) - serialised = self._primitive_value_to_str(value) - if not serialised: + if value is None: return [] - return [(key, serialised)] + return [(key, self._primitive_value_to_str(value))] def _primitive_value_to_str(self, value: PrimitiveData) -> str: # copied from httpx From 6b4e277cf9a82c3d3ebe7c12246b047cd046c60a Mon Sep 17 00:00:00 2001 From: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com> Date: Thu, 10 Sep 2026 03:18:28 +0100 Subject: [PATCH 2/2] test(querystring): cover empty string values --- tests/test_qs_empty_values.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 tests/test_qs_empty_values.py diff --git a/tests/test_qs_empty_values.py b/tests/test_qs_empty_values.py new file mode 100644 index 0000000000..658b74cc7c --- /dev/null +++ b/tests/test_qs_empty_values.py @@ -0,0 +1,19 @@ +from urllib.parse import unquote + +from openai._qs import stringify + + +def test_empty_string_scalar_is_preserved() -> None: + assert stringify({"filter": ""}) == "filter=" + + +def test_none_scalar_is_still_omitted() -> None: + assert stringify({"filter": None}) == "" + + +def test_nested_empty_string_is_preserved() -> None: + assert unquote(stringify({"filter": {"name": ""}})) == "filter[name]=" + + +def test_empty_string_in_repeat_array_is_preserved() -> None: + assert stringify({"filter": ["", "active"]}) == "filter=&filter=active"