Skip to content

facilityType ID/prefLabel are not checked against the canonical list #414

Description

@lukehesluke

How to reproduce

  1. Go to the FacilityUse example in validator
  2. Change facilityType[0].@id to https://doesntexist9127301.com
  3. Change facilityType[0].prefLabel to Tennis Courp
  4. Run "Validate"
  5. See that it doesn't register the changes as errors, even though this is now an incorrect facilityType

What it should do

Validator should act as it does for activity. If you load up the SessionSeries example, and change the activity[0].@id and activity[0].prefLabel to incorrect values, an error message is shown

It's worth noting, however, that, even for activity, the error checking is incomplete. If you only change the prefLabel, e.g. to Schbodypump™, there will be no error.

Therefore, a stretch goal of this task might be to have the activity and facilityType validation check that the prefLabel is correct for the ID

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions