[finding] DeclaredActionsBar keeps an inline copy of the three-way row binding now named `usePredicateRecordContext`

[yinlianghui]

Out-of-scope finding from objectui#4075 / PR #4079. Filed per PD #10 — unassigned, ungraded. Observation-class: nothing a user hits today, both copies are correct and produce identical bags.

Fact

PR #4077 fixed the root-only predicate binding in DeclaredActionsBar (packages/app-shell/src/views/DeclaredActionsBar.tsx) by building the bag inline:

const predicateContext = useMemo(
  () => ({ ...recordData, record: recordData, data: recordData }),
  [record],
);

PR #4079 fixed the same fault on the four generic action renderers and, rather than repeating that expression four more times, gave the rule one name: usePredicateRecordContext, exported from @object-ui/react beside useCondition (packages/react/src/hooks/useExpression.ts). @object-ui/app-shell already depends on @object-ui/react and DeclaredActionsBar already imports useCondition from it, so the migration is an import plus a one-line substitution.

Why it is worth recording rather than fixing in that PR

Two implementations of one binding rule is the shape objectui#3367 / #3842 rule against, and this family has already paid for it once at the toPredicateInput level (#3314 — two normalizations drifted, and the same visible: predicate reached different verdicts depending on which path surfaced the action). Nothing has drifted here yet; the risk is that the next change to the rule lands on one copy.

One non-cosmetic difference already exists, and it is the reason this is a real migration rather than a rename. usePredicateRecordContext returns an empty bag when there is no row, instead of { record: {}, data: {} } — because useCondition merges the local context OVER the ambient predicate scope, so binding an empty record blanks out a record a host put in the scope itself (a legitimate pattern, and how action-group-dropdown-visible.test.tsx drives those leaves; it went red on the first cut of #4079). DeclaredActionsBar's inline copy does not make that distinction. It is unreachable there today — the bar is always mounted over a record — so this is not a defect report, but the migration must keep the helper's semantics rather than restore the inline ones.

Suggested disposition

Migrate DeclaredActionsBar onto usePredicateRecordContext and delete the inline useMemo, keeping the helper's no-row semantics. Small, no user-visible change, no changeset.

Dedup

Searched open issues for DeclaredActionsBar predicate binding record, usePredicateRecordContext, three ways binding duplicate. Only objectui#4075 (this finding's parent, being closed by #4079) matches; no issue covers the duplicate implementation.

Refs: objectui#4075, objectui#4077, PR #4079, objectui#3367, objectui#3842, objectui#3314.

[os-zhuang]

Findings triage: promoted — finding → pm:queue (whole-repo backlog; no domain label in this repo by design).

• Premise check (origin/main @ 9154d9e): the inline copy is live at packages/app-shell/src/views/DeclaredActionsBar.tsx:149 ({ ...recordData, record: recordData, data: recordData }), and the named helper exists — usePredicateRecordContext exported at packages/react/src/hooks/useExpression.ts:142. PR fix(components): bind the row three ways on the four action renderers (#4075) #4079 has merged, so the migration target is real, not pending.
• Grade rationale: promoted rather than held despite being observation-class on impact, because it is fully specified — one import plus a one-line substitution, with the single semantic subtlety (keep the helper's empty-bag-when-no-row behaviour, do not restore the inline {record:{}, data:{}} shape) already written down on this card and pinned by action-group-dropdown-visible.test.tsx. Zero open questions is what separates it from held consolidation findings. The duplicate-binding family has already produced one real defect at the toPredicateInput level (ActionEngine.getActionsForLocation 把 CEL 信封塌回 legacy JS 求值路径,与每个渲染器的判决不一致 #3314: two normalizations drifted, same predicate, different verdicts), so leaving the second copy standing is the known failure shape of toPredicateInput 仍有两份实现(core canonical / react 渲染器侧),应让 react 直接 re-export core #3367/动作 disabled 的「已声明」判定用 != null,disabled: '' 把按钮永久置灰(#3492 同族的另一半 predicate,探针实证) #3842.
• Dedup: filer's searches confirmed; console: action:button / action:icon / action:menu bind the row only at the bare root, so a declared visible written as record.* faults and fails closed #4075 closes via fix(components): bind the row three ways on the four action renderers (#4075) #4079, no card covers the duplicate.

本评论来自分诊座位 Routine（#5474 试点），不构成认领。

---

Generated by Claude Code