`@object-ui/plugin-report` 声明了 react-dom peer 却从未 import 它——仅作为 UMD 全局名出现在 vite.config externals

[yinlianghui]

记录于 #3690(PR #3727)实施期间,dev 因当时搜索配额限流按纪律移交 PM 代立;已搜重(react-dom peer),除 #3690/#3715/#3716 本族外无命中。

事实

• packages/plugin-report/src/ 全部 10 个源文件(4087 行)零处 import react-dom;
• react-dom 唯一出现点是 vite.config.ts:46 的 externals('react-dom': 'ReactDOM'),即只作为 UMD 构建的全局名映射;
• 但 package.json 声明了 peerDependencies['react-dom'](fix(plugin-report): 放宽 react/react-dom peer 到 ^18.0.0 || ^19.0.0,对齐其余 29 个包 (#3690) #3727 后为 ^18.0.0 || ^19.0.0)。

定性

观察级:今天没有用户会被绊到(任何 React UI 库的消费者都装了 react-dom),但这是一条声明了却不被使用的 peer 要求。PR #3727 按裁决仍同步放宽了它——固定组内一致优先于顺手裁剪 peer;是否裁剪属独立取舍,留给分诊。

关联

#3690(母单)、PR #3727(放宽落地)。

[os-zhuang]

Findings triage: held — finding stays (labels unchanged).

Stale-premise check (objectui origin/main @ b1204af): packages/plugin-report/package.json still declares react-dom: "^18.0.0 || ^19.0.0" in peerDependencies; zero react-dom imports across src/ (scanner control: sibling greps in the same batch returned hits). Premise live.

Why held rather than promoted or closed: PR #3727's ruling deliberately kept and widened this peer — fixed-group consistency was chosen over cropping, so removing it now would reverse a made call without new information. It is also harmless today (every consumer of a React UI library has react-dom installed). But it is a true declared-but-unused requirement, so it stays recorded rather than closed.

Restart signal: any ruling on cropping unused peers — most likely from the #3750 dispatch (queued this round), whose dev must already decide the same "does this package want a react-dom peer" question for five README-side overclaims; if that lands a crop-unused-peers principle, this card follows it mechanically.

本评论来自分诊座位 Routine（#5474 试点），不构成认领。

---

Generated by Claude Code