Skip to content

Commit 08f803e

Browse files
committed
fix(tests): the conformance fixture read uses orderBy, the key DriverQuery declares (#6409)
`sort` is not a member of QueryAST; the fixture read-back compiled locally only because the package typecheck had not been re-run since the suite was written. Caught by CI's workspace typecheck, which the local gate enumeration had missed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RWMbS2ctjZSADPJiSdUtMA
1 parent 9b9b429 commit 08f803e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

packages/drivers/driver-sql/src/sql-driver-aggregation-conformance.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ describe('[#6409] SqlDriver — aggregate vocabulary conformance', () => {
118118
* seed is most likely to mangle.
119119
*/
120120
it('the fixture is all six rows, with the nulls stored AS nulls', async () => {
121-
const rows = await driver.find(CONFORMANCE_OBJECT.name, { sort: [{ field: 'id', order: 'asc' }] });
121+
const rows = await driver.find(CONFORMANCE_OBJECT.name, { orderBy: [{ field: 'id', order: 'asc' }] });
122122
expect(rows.map((r: any) => String(r.id))).toEqual(['1', '2', '3', '4', '5', '6']);
123123
for (const r of rows as any[]) {
124124
const seeded = AGGREGATION_ROWS.find((s) => s.id === String(r.id))!;

packages/drivers/driver-sqlite-wasm/src/sqlite-wasm-aggregation-conformance.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ describe('[#6409] driver-sqlite-wasm — aggregate vocabulary conformance', () =
6969
});
7070

7171
it('the fixture is all six rows, with the nulls stored AS nulls', async () => {
72-
const rows = await driver.find(OBJECT, { sort: [{ field: 'id', order: 'asc' }] });
72+
const rows = await driver.find(OBJECT, { orderBy: [{ field: 'id', order: 'asc' }] });
7373
expect(rows).toHaveLength(6);
7474
expect((rows as any[]).filter((r) => r.stage === null)).toHaveLength(2);
7575
});

0 commit comments

Comments
 (0)