Skip to content

Commit f01bc16

Browse files
authored
typings: add typing for permission binding
Add type declarations for the `permission` internalBinding so lib/internal/process/permission.js gets editor autocomplete and type checking for `has()` and `drop()`. Signed-off-by: seungmin Nam <nhjbest22@g.skku.edu> PR-URL: #65385 Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 6fa4968 commit f01bc16

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

typings/globals.d.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import { MessagingBinding } from './internalBinding/messaging';
2323
import { ModulesBinding } from './internalBinding/modules';
2424
import { OptionsBinding } from './internalBinding/options';
2525
import { OSBinding } from './internalBinding/os';
26+
import { PermissionBinding } from './internalBinding/permission';
2627
import { ProcessBinding } from './internalBinding/process';
2728
import { ProcessWrapBinding } from './internalBinding/process_wrap';
2829
import { SeaBinding } from './internalBinding/sea';
@@ -67,6 +68,7 @@ interface InternalBindingMap {
6768
modules: ModulesBinding;
6869
options: OptionsBinding;
6970
os: OSBinding;
71+
permission: PermissionBinding;
7072
process: ProcessBinding;
7173
process_wrap: ProcessWrapBinding;
7274
sea: SeaBinding;
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
type Buffer = Uint8Array;
2+
3+
export interface PermissionBinding {
4+
has(scope: string, reference?: string | Buffer | null): boolean;
5+
drop(scope: string, reference?: string | Buffer | null): void;
6+
}

0 commit comments

Comments
 (0)