Commit a16deb3
committed
repl: pass objectGroup to Runtime.awaitPromise
When the inspector-backed REPL evaluates a promise-returning
expression, Runtime.evaluate stores the remote promise object in an
objectGroup.
Runtime.awaitPromise did not pass objectGroup. Under GC pressure,
the remote promise object could be collected before the await
completed, causing the inspector to report:
-32000: Promise was collected
This surfaced in the REPL as ERR_INSPECTOR_COMMAND instead of the
user's original exception.
Pass objectGroup to Runtime.awaitPromise so the promise remains
retained until the await completes.
Fixes: #64762
Signed-off-by: Divyanshu Sharma <divyanshu88999@gmail.com>1 parent 4a5eb1c commit a16deb3
1 file changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
179 | 179 | | |
180 | 180 | | |
181 | 181 | | |
182 | | - | |
183 | | - | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
184 | 186 | | |
185 | 187 | | |
186 | 188 | | |
187 | 189 | | |
188 | 190 | | |
| 191 | + | |
189 | 192 | | |
190 | 193 | | |
191 | 194 | | |
| |||
0 commit comments