http: fix chunked write coalescing CI failures

Author: GetThatCookie

lib/_http_outgoing.js

@@ -328,21 +328,18 @@ OutgoingMessage.prototype.uncork = function uncork() {
     }
     assert(this.chunkedEncoding);
 
-    let callbacks;
+    const callbacks = [];
     this._send(len.toString(16), 'latin1', null);
     this._send(crlf_buf, null, null);
     for (let n = 0; n < buf.length; n += 3) {
       this._send(buf[n + 0], buf[n + 1], null);
-      if (buf[n + 2]) {
-        callbacks ??= [];
-        callbacks.push(buf[n + 2]);
-      }
+      callbacks.push(buf[n + 2]);
     }
-    this._send(crlf_buf, null, callbacks.length ? (err) => {
+    this._send(crlf_buf, null, (err) => {
       for (const callback of callbacks) {
         callback(err);
       }
-    } : null);
+    });
 
     this[kChunkedBuffer].length = 0;
     this[kChunkedLength] = 0;
@@ -1033,7 +1030,7 @@ function write_(msg, chunk, encoding, callback, fromEnd) {
 
   if (!fromEnd && msg.socket && !msg.socket.writableCorked) {
     msg.cork();
-    process.nextTick(connectionCorkNT, msg, msg.socket);
+    process.nextTick(connectionCorkNT, msg);
   }
 
   let ret;
@@ -1083,13 +1080,10 @@ function maybePrepareFinalChunk(msg, chunk, encoding) {
   return !!msg._header && msg._hasBody && !msg.chunkedEncoding;
 }
 
-function connectionCorkNT(msg, conn) {
+function connectionCorkNT(msg) {
   if (msg[kCorked]) {
     msg.uncork();
   }
-  if (msg[kSocket] !== conn) {
-    conn.uncork();
-  }
 }
 
 OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {

test/parallel/test-http-byteswritten.js

@@ -44,10 +44,10 @@ const httpServer = http.createServer(common.mustCall(function(req, res) {
     res.write(bchunk);
     res.write(chunk, 'hex');
   }
-  // Get .bytesWritten while buffer is not empty
-  assert(res.connection.bytesWritten > 0);
-
   res.end(body);
+
+  // Get .bytesWritten while the socket buffer is not empty.
+  assert(res.connection.bytesWritten > 0);
 }));
 
 httpServer.listen(0, function() {

test/parallel/test-webstreams-pipeline.js

@@ -212,7 +212,7 @@ const http = require('http');
         values.push(chunk?.toString());
       });
       res.on('end', common.mustCall(() => {
-        assert.deepStrictEqual(values, ['hello', 'world']);
+        assert.strictEqual(values.join(''), 'helloworld');
         server.close();
       }));
     }));