From 447d03ae896b3261418d361e055a3ca5d4bf387a Mon Sep 17 00:00:00 2001 From: mohit-emerson Date: Thu, 22 Oct 2026 10:51:42 +0000 Subject: [PATCH 1/6] test modified --- src/nirfsa/system_tests/test_system_nirfsa.py | 2 -- src/nirfsg/system_tests/test_system_nirfsg.py | 1 - 2 files changed, 3 deletions(-) diff --git a/src/nirfsa/system_tests/test_system_nirfsa.py b/src/nirfsa/system_tests/test_system_nirfsa.py index 1ae59025b..49b5ce2af 100644 --- a/src/nirfsa/system_tests/test_system_nirfsa.py +++ b/src/nirfsa/system_tests/test_system_nirfsa.py @@ -181,7 +181,6 @@ def test_reset_with_options(self, rfsa_device_session): rfsa_device_session.ports[''].deembedding_selected_table = 'myTable1' try: rfsa_device_session.commit() - assert False except nirfsa.Error as e: assert e.code == -1074097772 assert 'de-embedding table cannot be found' in e.description @@ -573,7 +572,6 @@ def test_create_deembedding_sparameter_table_s2p_file(self, rfsa_device_session) rfsa_device_session.delete_all_deembedding_tables() try: rfsa_device_session.commit() - assert False except nirfsa.Error as e: assert e.code == -1074097772 assert 'de-embedding table cannot be found' in e.description diff --git a/src/nirfsg/system_tests/test_system_nirfsg.py b/src/nirfsg/system_tests/test_system_nirfsg.py index 965d960ac..6e05d868d 100644 --- a/src/nirfsg/system_tests/test_system_nirfsg.py +++ b/src/nirfsg/system_tests/test_system_nirfsg.py @@ -579,7 +579,6 @@ def test_create_deembedding_sparameter_table_s2p_file(self, rfsg_device_session) rfsg_device_session.delete_all_deembedding_tables() try: rfsg_device_session.commit() - assert False except nirfsg.Error as e: assert e.code == -1074097772 assert 'The specified de-embedding table cannot be found' in e.description From 6c462efeb3201ec857240c92b48035c809778855 Mon Sep 17 00:00:00 2001 From: mohit-emerson Date: Thu, 22 Oct 2026 10:51:48 +0000 Subject: [PATCH 2/6] changelog updated --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 86a8d9eb3..1fa9f4f6a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1739,6 +1739,8 @@ - Added - (Common) Added `nitlsconfig[grpc]>=1.0.0a2` to the optional gRPC dependencies. - Changed + - Modified test `test_create_deembedding_sparameter_table_s2p_file` to match with the underlying driver behaviour + - Modified test `test_reset_with_options` to match with the underlying driver behaviour - Removed #### [nirfsa] 1.0.0 - 2026-08-20 @@ -1757,6 +1759,7 @@ - Added - (Common) Added `nitlsconfig[grpc]>=1.0.0a2` to the optional gRPC dependencies. - Changed + - Modified test `test_create_deembedding_sparameter_table_s2p_file` to match with the underlying driver behaviour - Removed #### [nirfsg] 1.2.0 - 2026-07-29 From 949b2b0643eef2e494bddd790ced698a246a4d74 Mon Sep 17 00:00:00 2001 From: mohit-emerson Date: Thu, 22 Oct 2026 11:41:08 +0000 Subject: [PATCH 3/6] PR comments --- CHANGELOG.md | 3 --- src/nirfsa/system_tests/test_system_nirfsa.py | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1fa9f4f6a..86a8d9eb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1739,8 +1739,6 @@ - Added - (Common) Added `nitlsconfig[grpc]>=1.0.0a2` to the optional gRPC dependencies. - Changed - - Modified test `test_create_deembedding_sparameter_table_s2p_file` to match with the underlying driver behaviour - - Modified test `test_reset_with_options` to match with the underlying driver behaviour - Removed #### [nirfsa] 1.0.0 - 2026-08-20 @@ -1759,7 +1757,6 @@ - Added - (Common) Added `nitlsconfig[grpc]>=1.0.0a2` to the optional gRPC dependencies. - Changed - - Modified test `test_create_deembedding_sparameter_table_s2p_file` to match with the underlying driver behaviour - Removed #### [nirfsg] 1.2.0 - 2026-07-29 diff --git a/src/nirfsa/system_tests/test_system_nirfsa.py b/src/nirfsa/system_tests/test_system_nirfsa.py index 49b5ce2af..61f44e03f 100644 --- a/src/nirfsa/system_tests/test_system_nirfsa.py +++ b/src/nirfsa/system_tests/test_system_nirfsa.py @@ -181,6 +181,7 @@ def test_reset_with_options(self, rfsa_device_session): rfsa_device_session.ports[''].deembedding_selected_table = 'myTable1' try: rfsa_device_session.commit() + assert False except nirfsa.Error as e: assert e.code == -1074097772 assert 'de-embedding table cannot be found' in e.description From db033c39ef4571f8d4f17b2089c91027f2d1c184 Mon Sep 17 00:00:00 2001 From: mohit-emerson Date: Thu, 22 Oct 2026 12:18:50 +0000 Subject: [PATCH 4/6] test_reset_with_options modified --- src/nirfsa/system_tests/test_system_nirfsa.py | 1 - 1 file changed, 1 deletion(-) diff --git a/src/nirfsa/system_tests/test_system_nirfsa.py b/src/nirfsa/system_tests/test_system_nirfsa.py index 61f44e03f..49b5ce2af 100644 --- a/src/nirfsa/system_tests/test_system_nirfsa.py +++ b/src/nirfsa/system_tests/test_system_nirfsa.py @@ -181,7 +181,6 @@ def test_reset_with_options(self, rfsa_device_session): rfsa_device_session.ports[''].deembedding_selected_table = 'myTable1' try: rfsa_device_session.commit() - assert False except nirfsa.Error as e: assert e.code == -1074097772 assert 'de-embedding table cannot be found' in e.description From f1a37cc776e501c8bf603ae40e6a0e70189f3acf Mon Sep 17 00:00:00 2001 From: mohit-emerson Date: Thu, 22 Oct 2026 14:06:07 +0000 Subject: [PATCH 5/6] PR comments addressed --- src/nirfsa/system_tests/test_system_nirfsa.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/nirfsa/system_tests/test_system_nirfsa.py b/src/nirfsa/system_tests/test_system_nirfsa.py index 49b5ce2af..1b27807f8 100644 --- a/src/nirfsa/system_tests/test_system_nirfsa.py +++ b/src/nirfsa/system_tests/test_system_nirfsa.py @@ -179,11 +179,7 @@ def test_reset_with_options(self, rfsa_device_session): # Reset with no omitted steps deletes the de-embedding tables. rfsa_device_session.reset_with_options(steps_to_omit_none) rfsa_device_session.ports[''].deembedding_selected_table = 'myTable1' - try: - rfsa_device_session.commit() - except nirfsa.Error as e: - assert e.code == -1074097772 - assert 'de-embedding table cannot be found' in e.description + rfsa_device_session.commit() @pytest.mark.skipif(use_simulated_session is False, reason="Takes long time on real device") def test_self_cal_range(self, rfsa_device_session): From 86c6df705e5f90218499fbe84f4a2dcf8e0771f7 Mon Sep 17 00:00:00 2001 From: mohit-emerson Date: Thu, 22 Oct 2026 16:28:05 +0000 Subject: [PATCH 6/6] try catch block removed --- src/nirfsa/system_tests/test_system_nirfsa.py | 6 +----- src/nirfsg/system_tests/test_system_nirfsg.py | 6 +----- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/nirfsa/system_tests/test_system_nirfsa.py b/src/nirfsa/system_tests/test_system_nirfsa.py index 1b27807f8..34deeb428 100644 --- a/src/nirfsa/system_tests/test_system_nirfsa.py +++ b/src/nirfsa/system_tests/test_system_nirfsa.py @@ -566,11 +566,7 @@ def test_create_deembedding_sparameter_table_s2p_file(self, rfsa_device_session) with rfsa_device_session.initiate(): rfsa_device_session.check_acquisition_status() rfsa_device_session.delete_all_deembedding_tables() - try: - rfsa_device_session.commit() - except nirfsa.Error as e: - assert e.code == -1074097772 - assert 'de-embedding table cannot be found' in e.description + rfsa_device_session.commit() rfsa_device_session.ports[''].deembedding_selected_table = '' with rfsa_device_session.initiate(): rfsa_device_session.check_acquisition_status() diff --git a/src/nirfsg/system_tests/test_system_nirfsg.py b/src/nirfsg/system_tests/test_system_nirfsg.py index 6e05d868d..c77f2f509 100644 --- a/src/nirfsg/system_tests/test_system_nirfsg.py +++ b/src/nirfsg/system_tests/test_system_nirfsg.py @@ -577,11 +577,7 @@ def test_create_deembedding_sparameter_table_s2p_file(self, rfsg_device_session) with rfsg_device_session.initiate(): rfsg_device_session.check_generation_status() rfsg_device_session.delete_all_deembedding_tables() - try: - rfsg_device_session.commit() - except nirfsg.Error as e: - assert e.code == -1074097772 - assert 'The specified de-embedding table cannot be found' in e.description + rfsg_device_session.commit() rfsg_device_session.ports[''].deembedding_selected_table = '' with rfsg_device_session.initiate(): rfsg_device_session.check_generation_status()