From 2fc9fa2807f95145f3233e9dbdb0c6973d094870 Mon Sep 17 00:00:00 2001 From: daniele-verducci Date: Fri, 30 Oct 2026 19:03:27 +0100 Subject: [PATCH 1/3] Fixed empty view not triggered in Media due to EmptyRecyclerView still expecting a footer Signed-off-by: daniele-verducci --- .../owncloud/android/ui/fragment/GalleryFragment.kt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt index df6cacb57753..310af5390d61 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt @@ -213,6 +213,11 @@ class GalleryFragment : } override fun setAdapter(args: Bundle?) { + // update the footer as there is no footer shown in media view + if (recyclerView is EmptyRecyclerView) { + (recyclerView as EmptyRecyclerView).setHasFooter(false) + } + galleryAdapter = GalleryAdapter( requireContext(), accountManager.user, @@ -226,11 +231,6 @@ class GalleryFragment : galleryAdapter?.setHasStableIds(true) setRecyclerViewAdapter(galleryAdapter) - // update the footer as there is no footer shown in media view - if (recyclerView is EmptyRecyclerView) { - (recyclerView as EmptyRecyclerView).setHasFooter(false) - } - binding?.paginationProgress?.let { viewThemeUtils.platform.colorCircularProgressBar(it, ColorRole.PRIMARY) } From fec574b98111686324eb4e6098fd56f4fb3512d1 Mon Sep 17 00:00:00 2001 From: Daniele Verducci Date: Mon, 2 Nov 2026 16:24:26 +0100 Subject: [PATCH 2/3] Oneliner with null casting for setHasFooter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Alper Öztürk <67455295+alperozturk96@users.noreply.github.com> Signed-off-by: Daniele Verducci --- .../java/com/owncloud/android/ui/fragment/GalleryFragment.kt | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt index 310af5390d61..6947d965ede3 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt @@ -213,10 +213,7 @@ class GalleryFragment : } override fun setAdapter(args: Bundle?) { - // update the footer as there is no footer shown in media view - if (recyclerView is EmptyRecyclerView) { - (recyclerView as EmptyRecyclerView).setHasFooter(false) - } +(recyclerView as? EmptyRecyclerView)?.setHasFooter(false) galleryAdapter = GalleryAdapter( requireContext(), From 3ec1c781d96a2d82cdd05b4967e5527ba4416f8c Mon Sep 17 00:00:00 2001 From: daniele-verducci Date: Mon, 2 Nov 2026 17:42:07 +0100 Subject: [PATCH 3/3] Spotless Signed-off-by: daniele-verducci --- .../java/com/owncloud/android/ui/fragment/GalleryFragment.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt index 6947d965ede3..056d570bbbaf 100644 --- a/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt +++ b/app/src/main/java/com/owncloud/android/ui/fragment/GalleryFragment.kt @@ -213,7 +213,7 @@ class GalleryFragment : } override fun setAdapter(args: Bundle?) { -(recyclerView as? EmptyRecyclerView)?.setHasFooter(false) + (recyclerView as? EmptyRecyclerView)?.setHasFooter(false) galleryAdapter = GalleryAdapter( requireContext(),