From 287ed66fecae31f8446f1084cc386c1e55239c5b Mon Sep 17 00:00:00 2001 From: Sebastian Mendel Date: Wed, 5 Aug 2026 09:13:31 +0200 Subject: [PATCH] fix(deps): unpin rector, apply what the newer version finds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The exact pin came from "hold rector at 2.4.5 during lockfile maintenance" (2026-07-05) and has been carried forward by dependency bumps ever since; the maintenance it was holding for is long done. An exact constraint means a new Rector reaches this repo only when someone opens a bump PR, which is the opposite of the org rule that new analysis rules take effect immediately. Unpinning moves 2.5.8 -> 2.6.1 here, so this is not a no-op like the same change in typo3-ci-workflows was. Two consequences, both handled: - The 2.6.0 removal of SetList::STRICT_BOOLEANS, which broke the TYPO3 fleet, does not apply: config/quality/rector.php never referenced it. - 2.6.x reports ParamAndEnvAttributeRector on two constructors. Applied rather than deferred, which is the whole point of dropping the pin. #[Autowire('%param%')] becomes #[Autowire(param: 'param')] — the same container wiring in the form Symfony documents. The composer.lock change is rector and nothing else. Signed-off-by: Sebastian Mendel --- composer.json | 2 +- composer.lock | 14 +++++++------- src/EventSubscriber/RequireTwoFactorSubscriber.php | 2 +- .../Security/TwoFactorEnrollmentService.php | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/composer.json b/composer.json index ec73ed63b..1e4eb6c02 100644 --- a/composer.json +++ b/composer.json @@ -89,7 +89,7 @@ "phpstan/phpstan-strict-rules": "*", "phpstan/phpstan-symfony": "^2.0", "phpunit/phpunit": "^13.0", - "rector/rector": "2.5.8", + "rector/rector": "^2.0", "struggle-for-php/sfp-phpstan-psr-log": "*", "symfony/browser-kit": "^8.1", "symfony/debug-bundle": "^8.1", diff --git a/composer.lock b/composer.lock index a7273a394..dcf466c8e 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies", "This file is @generated automatically" ], - "content-hash": "bd6312d48c592ffd6300295476dc06e8", + "content-hash": "c6b56c13d86288093f2068cee65e45f7", "packages": [ { "name": "brick/math", @@ -11918,16 +11918,16 @@ }, { "name": "rector/rector", - "version": "2.5.8", + "version": "2.6.1", "source": { "type": "git", "url": "https://github.com/rectorphp/rector.git", - "reference": "861c77fd2a6d45317a401f4e0b617f947e8b6f96" + "reference": "b8e68f058bca43e01a2e1caa51ef022d6551ed95" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/rectorphp/rector/zipball/861c77fd2a6d45317a401f4e0b617f947e8b6f96", - "reference": "861c77fd2a6d45317a401f4e0b617f947e8b6f96", + "url": "https://api.github.com/repos/rectorphp/rector/zipball/b8e68f058bca43e01a2e1caa51ef022d6551ed95", + "reference": "b8e68f058bca43e01a2e1caa51ef022d6551ed95", "shasum": "" }, "require": { @@ -11966,7 +11966,7 @@ ], "support": { "issues": "https://github.com/rectorphp/rector/issues", - "source": "https://github.com/rectorphp/rector/tree/2.5.8" + "source": "https://github.com/rectorphp/rector/tree/2.6.1" }, "funding": [ { @@ -11974,7 +11974,7 @@ "type": "github" } ], - "time": "2026-07-27T06:19:16+00:00" + "time": "2026-08-03T17:30:34+00:00" }, { "name": "sebastian/cli-parser", diff --git a/src/EventSubscriber/RequireTwoFactorSubscriber.php b/src/EventSubscriber/RequireTwoFactorSubscriber.php index 661276093..dd056defa 100644 --- a/src/EventSubscriber/RequireTwoFactorSubscriber.php +++ b/src/EventSubscriber/RequireTwoFactorSubscriber.php @@ -72,7 +72,7 @@ public function __construct( private Security $security, private TwoFactorStatusService $status, private RouterInterface $router, - #[Autowire('%app_require_two_factor%')] + #[Autowire(param: 'app_require_two_factor')] private bool $required, ) { } diff --git a/src/Service/Security/TwoFactorEnrollmentService.php b/src/Service/Security/TwoFactorEnrollmentService.php index f7986c278..a00879d42 100644 --- a/src/Service/Security/TwoFactorEnrollmentService.php +++ b/src/Service/Security/TwoFactorEnrollmentService.php @@ -44,7 +44,7 @@ public function __construct( private TokenEncryptionService $tokenEncryptionService, private ClockInterface $clock, - #[Autowire('%app_title%')] + #[Autowire(param: 'app_title')] private string $issuer, ) { }