Possible bug [postgres]: line break between function parethesis when indented

[joelmukuthu]

This:

SELECT 
FROM foo 
WHERE bar = looooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name();

Gets transformed to:

SELECT
FROM foo
WHERE
  bar = looooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name(

  );

Whereas my expectation would be:

SELECT
FROM foo
WHERE
  bar = looooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name();

[nene]

Thanks for reporting.

Two ways of solving this. Potentially with both.

1. allow breaking up binary operators to multiple lines:

SELECT
FROM foo
WHERE
  bar =
    looooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name();

That will alleviate the problem, but will not completely fix it.

2. never split the empty function args to multiple lines.

As suggested above.

The problematic bit is that we also need to account for potential comments inside that empty ( ... ) part.

[joelmukuthu]

Thanks for the quick response. Option 1 is a desirable pattern for my project, so even I'd be happy with that change on it's own :) Wrt option 2, could the the presence of comments between the parens be deemed as "not empty function args", so it's split into multiple lines?

WHERE 
  looooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name(
    /* comment */
  );
-- OR
WHERE 
  looooooooooooooooooooooooooooooooooooooooooooooooooooong_function_name(
    -- comment
  );