Feature request: search box

[anupshah]

Hi,

Not sure how easy this will be, but would be nice to have ability to search through the entire pull requests for comments or code or something. Without BitbucketDiffTree you can just use the browser's find feature.

Now with the tree control that can't be used. So maybe a search box to do something similar could be useful?

If it helps: a use case: I have a few email notifications of various comments. In the middle the PR page has to be reloaded, so the badge count in BitBucket gets reset. Looking at the email and copying part of the message and finding it on the page helps me carry on quickly...

[minhdam]

Hi @anupshah,

If it helps: a use case: I have a few email notifications of various comments. In the middle the PR page has to be reloaded, so the badge count in BitBucket gets reset. Looking at the email and copying part of the message and finding it on the page helps me carry on quickly...

I have implemented this in v1.4.7. Please check if it works for you.

Not sure how easy this will be, but would be nice to have ability to search through the entire pull requests for comments or code or something. Without BitbucketDiffTree you can just use the browser's find feature.

The search feature will be ready for the next version. Some other people are also requesting it. Thanks.

[anupshah]

Hi. Just double checking, which part have you implemented in 1.4.7?

Edit: just saw the commits. I see it now. I will check soon and let you know. (I think I saw this working this morning but will double check.) Many thanks!

[minhdam]

Anup, the search function is now available in version 1.5. Please give it a try. :-)

[anupshah]

Hi. Thanks. Unfortunately I don't think it is working for me? I can see that after about 3 or 4 characters it may filter on the files, though if I type more characters the filtering on files stops working. Also it doesn't appear to search through the code, is that right?

[minhdam]

Currently, it only searches for files' and/or folders' name. The search results will be filtered and highlighted. If there is no result, it will display all the files and folders without any highlighted. That's why you felt the search stopped working :-).

Also, it's not supporting code search. I'm thinking to put it in the next version if it's an actual need.

[anupshah]

Hi. Thanks for your reply. Yeah, code searching was the main part of this feature request to be honest. File filtering is useful for sure, but given we can't just use browser's find any more searching code on the page to me is really useful. (Simple example, in addition to the use case in the original request: a PR introduces a new method in one class in one file. I can do a simple search to find that method elsewhere in the PR to see where it is used, so I can follow the code a bit more.)

[minhdam]

@anupshah
Sorry for misunderstanding your need. I will consider implementing the code search in the next version.
Thanks.

[anupshah]

Many thanks and no problem. Just grateful you have made this extension! Look forward to the next version!