From 64e565f28a9f12722be87d75691be95e3b73f61f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Deniz=20G=C3=BCney=20Y=C4=B1ld=C4=B1r=C4=B1m?= <31777283+denizguney@users.noreply.github.com> Date: Thu, 27 Aug 2026 23:00:09 +0300 Subject: [PATCH 1/2] Enhance jsonvalue_test.go with edge case tests Add unit tests covering edge cases for `jsonvalueToAny`, including empty objects (`{}`), boolean types, and floating-point values to ensure robust parsing across various data structures. --- tsc/internal/api/jsonvalue_test.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tsc/internal/api/jsonvalue_test.go b/tsc/internal/api/jsonvalue_test.go index 90903bef4ea73..55af82d2d85b8 100644 --- a/tsc/internal/api/jsonvalue_test.go +++ b/tsc/internal/api/jsonvalue_test.go @@ -32,4 +32,19 @@ func TestJSONValueToAny(t *testing.T) { empty := root.GetOrZero("e").([]any) assert.Assert(t, empty != nil) assert.Equal(t, len(empty), 0) + + + var edgeValue packagejson.JSONValue + err = json.Unmarshal([]byte(`{"emptyObj":{},"boolVal":true,"floatVal":3.14}`), &edgeValue) + assert.NilError(t, err) + + edgeRoot := jsonValueToAny(edgeValue).(*collections.OrderedMap[string, any]) + + + emptyObj := edgeRoot.GetOrZero("emptyObj").(*collections.OrderedMap[string, any]) + assert.Equal(t, len(slices.Collect(emptyObj.Keys())), 0) + + + assert.Equal(t, edgeRoot.GetOrZero("boolVal"), true) + assert.Equal(t, edgeRoot.GetOrZero("floatVal"), float64(3.14)) } From d0f17b756423bdd5f945cd10fbeac56862d4ff3a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Deniz=20G=C3=BCney=20Y=C4=B1ld=C4=B1r=C4=B1m?= <31777283+denizguney@users.noreply.github.com> Date: Thu, 27 Aug 2026 23:33:25 +0300 Subject: [PATCH 2/2] Clean up jsonvalue_test.go by removing extra lines Fix Go formatting check by removing whitespace-only blank lines in jsonvalue_test.go. --- tsc/internal/api/jsonvalue_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tsc/internal/api/jsonvalue_test.go b/tsc/internal/api/jsonvalue_test.go index 55af82d2d85b8..89bb9ac165cad 100644 --- a/tsc/internal/api/jsonvalue_test.go +++ b/tsc/internal/api/jsonvalue_test.go @@ -33,18 +33,15 @@ func TestJSONValueToAny(t *testing.T) { assert.Assert(t, empty != nil) assert.Equal(t, len(empty), 0) - var edgeValue packagejson.JSONValue err = json.Unmarshal([]byte(`{"emptyObj":{},"boolVal":true,"floatVal":3.14}`), &edgeValue) assert.NilError(t, err) edgeRoot := jsonValueToAny(edgeValue).(*collections.OrderedMap[string, any]) - - + emptyObj := edgeRoot.GetOrZero("emptyObj").(*collections.OrderedMap[string, any]) assert.Equal(t, len(slices.Collect(emptyObj.Keys())), 0) - assert.Equal(t, edgeRoot.GetOrZero("boolVal"), true) assert.Equal(t, edgeRoot.GetOrZero("floatVal"), float64(3.14)) }