[Extensibility request] Page 46 "Sales Order Subform" – OnValidate("Description")

[Mariangela-DeMaio-EOS]

Why do you need this change?

Hi,
Starting from BC 28.1, a change in the Base Application affects the behavior of the OnValidate trigger of the "Description" field in the Sales Order Subform (Page 46).

The current implementation introduces functional regressions, especially for extensions relying on in-memory modifications of Sales Line.

The code modification causes the recalculation of all totals in the document; this is an excessive and not necessarily use of logic, that could be reduced only if relevant line fields are changing.

Current behavior

DeltaUpdateTotals is executed before the following check:

if Rec."No." = xRec."No." then 

    exit; 

Causes unnecessary executions even when the Item No. is unchanged.

A new procedure CalculateTotals is invoked:

• Triggers a full document recalculation
• Performs record reload from the database

Due to the reload:

• Any in-memory changes on Sales Line are lost, unless explicitly persisted before validating "Description"

Describe the request

Move at least the following procedures:

DeltaUpdateTotals
CalculateTotals

after:

if Rec."No." = xRec."No." then 

    exit; 

This ensures:

• Execution only when the Item No. changes
• Reduced unnecessary recalculations
• Preservation of in-memory Sales Line modifications

@Andrea-Antolini-EOS

@Thomas-Torggler-EOS
Internal work item: AB#638322

[github-actions]

✅ Analysis complete - ready for further processing

---

Implementation:

Move the totals recalculation logic in OnValidate("Description") so CalculateTotals() and DeltaUpdateTotals() run only after the if Rec."No." = xRec."No." then exit; check.

Current code:

trigger OnValidate()
begin
    UpdateEditableOnRow();

    Rec.RestoreLookupSelection();
    NoOnAfterValidate();
    ResetxRecAmountValues();
    CalculateTotals();
    DeltaUpdateTotals();
    if Rec."No." = xRec."No." then
        exit;

    Rec.ShowShortcutDimCode(ShortcutDimCode);
    UpdateTypeText();
    OnAfterValidateDescription(Rec, xRec);
end;

Proposed change:

trigger OnValidate()
begin
    UpdateEditableOnRow();

    Rec.RestoreLookupSelection();
    NoOnAfterValidate();
    ResetxRecAmountValues();
    if Rec."No." = xRec."No." then
        exit;

    CalculateTotals(); // NEW
    DeltaUpdateTotals(); // NEW
    Rec.ShowShortcutDimCode(ShortcutDimCode);
    UpdateTypeText();
    OnAfterValidateDescription(Rec, xRec);
end;

---

File: SalesOrderSubform.Page.al

Note

Automatically generated by the Triage Agent — advisory only. An engineer will review before any action is taken.

Tip

Not accurate? Reply with /not-accurate (optional: add a short explanation). Your feedback improves future responses.