diff --git a/.github/workflows/prose-body-write.yml b/.github/workflows/prose-body-write.yml index 08fec36..7b629bb 100644 --- a/.github/workflows/prose-body-write.yml +++ b/.github/workflows/prose-body-write.yml @@ -18,6 +18,7 @@ # marker to distinguish a break the author wanted from one their editor made, # so this can join a break that was meant to stay. `` on # the line above a paragraph keeps it. + name: Prose body write on: @@ -28,4 +29,4 @@ jobs: edit: permissions: pull-requests: write - uses: michen00/markdown-prose-hooks/.github/workflows/unwrap-pr-body.yml@v0.4.0 + uses: michen00/markdown-prose-hooks/.github/workflows/unwrap-pr-body.yml@v0.5.0 diff --git a/.github/workflows/prose-body.yml b/.github/workflows/prose-body.yml index 4da5a09..382f75c 100644 --- a/.github/workflows/prose-body.yml +++ b/.github/workflows/prose-body.yml @@ -4,33 +4,7 @@ # at whatever width it was typed to. A file has the opposite problem -- the # break renders as a space and costs a reflowed diff -- and the pre-commit hook # covers that side. -# -# Deliberately narrower than the upstream example, which also carries `opened` -# and `reopened`. Those belong to prose-body-write.yml: sharing an event fires -# both at once, and this report would then describe a body the rewrite is about -# to replace. `edited` is not in the default type set and is the one that -# matters -- editing a body fires it alone, so without it a report would stand -# on a body the author has already fixed. -# -# `pull_request_target`, not `pull_request`, and the difference is who the -# report reaches. A fork's token is read-only whatever a caller's -# `permissions:` block asks for, so under `pull_request` the comment is refused -# for every outside contributor -- the people least likely to know this -# repository's prose convention, and the ones the report exists for. The run -# does not fail there and the report is not lost: the reusable workflow falls -# back to the job summary. But a summary is something you have to open a check -# to find, and a comment is not. -# -# What makes that safe here is that the reusable workflow checks out nothing -- -# it has no `actions/checkout` step at all. It reads the body from the event -# payload and posts a comment, so the usual `pull_request_target` hazard, a -# writable token handed to unreviewed code, has nothing to attach to. Keep it -# that way: adding a checkout of the pull request head under this trigger is -# what would turn it into the vulnerability the pattern is known for. -# -# The cost is the same one prose-body-write.yml pays. `pull_request_target` -# reads the workflow from the default branch, so a pull request cannot test a -# change to this file; it takes effect once merged. + name: Prose body on: @@ -43,4 +17,4 @@ jobs: # comment needs one, and the scope belongs on the calling job. permissions: pull-requests: write - uses: michen00/markdown-prose-hooks/.github/workflows/unwrap-pr-body-check.yml@v0.4.0 + uses: michen00/markdown-prose-hooks/.github/workflows/unwrap-pr-body-check.yml@v0.5.0