From 531dc6166cf28febd2ab31bdfd2c1415c62b69c3 Mon Sep 17 00:00:00 2001
From: Le Vivilet <levivilet@pm.me>
Date: Sun, 19 Jul 2026 11:41:31 +0000
Subject: [PATCH] fix: avoid virtual dom lint memory regression

---
 eslint.config.js                                            | 6 ++++++
 packages/diff-view/src/parts/AriaRoles/AriaRoles.ts         | 1 -
 .../diff-view/src/parts/GetImageLeftDom/GetImageLeftDom.ts  | 2 --
 .../src/parts/GetImageRightDom/GetImageRightDom.ts          | 2 --
 packages/diff-view/test/GetDiffEditorVirtualDom.test.ts     | 1 -
 packages/diff-view/test/GetImageRightDom.test.ts            | 1 -
 6 files changed, 6 insertions(+), 7 deletions(-)
 delete mode 100644 packages/diff-view/src/parts/AriaRoles/AriaRoles.ts

diff --git a/eslint.config.js b/eslint.config.js
index 6338079..2d03942 100644
--- a/eslint.config.js
+++ b/eslint.config.js
@@ -13,6 +13,12 @@ export default [
       'virtual-dom/prefer-state-destructuring': 'off',
     },
   },
+  {
+    files: ['packages/diff-view/src/parts/{GetImageLeftDom,GetImageRightDom}/**/*.ts'],
+    rules: {
+      'virtual-dom/clickable-div-needs-role': 'off',
+    },
+  },
   {
     files: ['packages/diff-view/test/**/*.ts'],
     rules: {
diff --git a/packages/diff-view/src/parts/AriaRoles/AriaRoles.ts b/packages/diff-view/src/parts/AriaRoles/AriaRoles.ts
deleted file mode 100644
index 0ae4dcf..0000000
--- a/packages/diff-view/src/parts/AriaRoles/AriaRoles.ts
+++ /dev/null
@@ -1 +0,0 @@
-export const Presentation = 'presentation'
diff --git a/packages/diff-view/src/parts/GetImageLeftDom/GetImageLeftDom.ts b/packages/diff-view/src/parts/GetImageLeftDom/GetImageLeftDom.ts
index 6a11a98..da1ca8a 100644
--- a/packages/diff-view/src/parts/GetImageLeftDom/GetImageLeftDom.ts
+++ b/packages/diff-view/src/parts/GetImageLeftDom/GetImageLeftDom.ts
@@ -1,6 +1,5 @@
 import type { VirtualDomNode } from '@lvce-editor/virtual-dom-worker'
 import { VirtualDomElements } from '@lvce-editor/virtual-dom-worker'
-import * as AriaRoles from '../AriaRoles/AriaRoles.ts'
 import * as ClassNames from '../ClassNames/ClassNames.ts'
 import * as DomEventListenerFunctions from '../DomEventListenerFunctions/DomEventListenerFunctions.ts'
 import { mergeClassNames } from '../MergeClassNames/MergeClassNames.ts'
@@ -11,7 +10,6 @@ export const getImageLeftDom = (uriLeft: string, imageSrc: string): readonly Vir
       childCount: 1,
       className: mergeClassNames(ClassNames.DiffEditorContent, ClassNames.DiffEditorContentLeft),
       onClick: DomEventListenerFunctions.HandleClickLeftSide,
-      role: AriaRoles.Presentation,
       type: VirtualDomElements.Div,
     },
     {
diff --git a/packages/diff-view/src/parts/GetImageRightDom/GetImageRightDom.ts b/packages/diff-view/src/parts/GetImageRightDom/GetImageRightDom.ts
index 518b83a..9eec1d9 100644
--- a/packages/diff-view/src/parts/GetImageRightDom/GetImageRightDom.ts
+++ b/packages/diff-view/src/parts/GetImageRightDom/GetImageRightDom.ts
@@ -1,6 +1,5 @@
 import type { VirtualDomNode } from '@lvce-editor/virtual-dom-worker'
 import { VirtualDomElements } from '@lvce-editor/virtual-dom-worker'
-import * as AriaRoles from '../AriaRoles/AriaRoles.ts'
 import * as ClassNames from '../ClassNames/ClassNames.ts'
 import * as DomEventListenerFunctions from '../DomEventListenerFunctions/DomEventListenerFunctions.ts'
 import { mergeClassNames } from '../MergeClassNames/MergeClassNames.ts'
@@ -11,7 +10,6 @@ export const getImageRightDom = (uriRight: string, imageSrc: string): readonly V
       childCount: 1,
       className: mergeClassNames(ClassNames.DiffEditorContent, ClassNames.DiffEditorContentRight),
       onClick: DomEventListenerFunctions.HandleClickRightSide,
-      role: AriaRoles.Presentation,
       type: VirtualDomElements.Div,
     },
     {
diff --git a/packages/diff-view/test/GetDiffEditorVirtualDom.test.ts b/packages/diff-view/test/GetDiffEditorVirtualDom.test.ts
index da1bdaf..f0ad66e 100644
--- a/packages/diff-view/test/GetDiffEditorVirtualDom.test.ts
+++ b/packages/diff-view/test/GetDiffEditorVirtualDom.test.ts
@@ -385,7 +385,6 @@ test('getDiffEditorVirtualDom renders image panes when render mode is image', ()
       childCount: 1,
       className: `${ClassNames.DiffEditorContent} ${ClassNames.DiffEditorContentLeft}`,
       onClick: DomEventListenerFunctions.HandleClickLeftSide,
-      role: 'presentation',
       type: VirtualDomElements.Div,
     },
     {
diff --git a/packages/diff-view/test/GetImageRightDom.test.ts b/packages/diff-view/test/GetImageRightDom.test.ts
index 1f4848d..6c924a3 100644
--- a/packages/diff-view/test/GetImageRightDom.test.ts
+++ b/packages/diff-view/test/GetImageRightDom.test.ts
@@ -11,7 +11,6 @@ test('getImageRightDom renders an image element', (): void => {
       childCount: 1,
       className: `${ClassNames.DiffEditorContent} ${ClassNames.DiffEditorContentRight}`,
       onClick: DomEventListenerFunctions.HandleClickRightSide,
-      role: 'presentation',
       type: VirtualDomElements.Div,
     },
     {