Skip to content

Commit ced79b8

Browse files
committed
name the agents session history check after its regression
1 parent 0b534d7 commit ced79b8

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

.github/workflows/protocol-agents-compat.yml renamed to .github/workflows/regression-agents-session-history.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Protocol / livekit-agents compatibility
1+
name: Regression - livekit-agents releases encode their session history
22

33
# Every published livekit-agents release must still encode its session history with a
44
# livekit-protocol 1.x build: those releases accept livekit-protocol<2 and are already deployed.
@@ -10,11 +10,11 @@ on:
1010
paths:
1111
- livekit-protocol/**
1212
- tests/protocol/**
13-
- .github/workflows/protocol-agents-compat.yml
13+
- .github/workflows/regression-agents-session-history.yml
1414
workflow_dispatch:
1515

1616
jobs:
17-
agents-releases:
17+
regression-agents-session-history:
1818
runs-on: ubuntu-latest
1919
steps:
2020
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
@@ -48,7 +48,7 @@ jobs:
4848
uv venv -q --allow-existing "venv-$v"
4949
VIRTUAL_ENV="venv-$v" uv pip install -q "livekit-agents==$v"
5050
VIRTUAL_ENV="venv-$v" uv pip install -q --no-deps --reinstall "$wheel"
51-
"venv-$v/bin/python" tests/protocol/agents_session_history.py || failed="$failed $v"
51+
"venv-$v/bin/python" tests/protocol/regression_agents_session_history.py || failed="$failed $v"
5252
done
5353
if [ -n "$failed" ]; then
5454
echo "::error::livekit-agents releases that cannot encode a session history:$failed"

tests/protocol/agents_session_history.py renamed to tests/protocol/regression_agents_session_history.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
"""Encode a session history the way an installed livekit-agents release uploads it.
1+
"""Regression: livekit-protocol 1.1.28 added FunctionCall.extra, and livekit-agents 1.7.0 to 1.8.8
2+
failed to upload the session history (TypeError: bad argument type for built-in operation).
3+
4+
Encodes a session history the way an installed livekit-agents release uploads it.
25
36
livekit-agents 1.7.0 to 1.8.8 fill every field the installed protocol declares on a chat item
47
from the attribute of the same name, so a new field can break releases already deployed.

0 commit comments

Comments
 (0)