diff --git a/.github/hooks/run_validation_after_edits.sh b/.github/hooks/run_validation_after_edits.sh index 0f6d9b86..234f61aa 100755 --- a/.github/hooks/run_validation_after_edits.sh +++ b/.github/hooks/run_validation_after_edits.sh @@ -6,31 +6,25 @@ payload="$(cat)" should_run="$(HOOK_PAYLOAD="$payload" python3 - <<'PY' import json import os -import sys -edit_tool_tokens = { +edit_tools = { "edit", "write", "multi_edit", "multiedit", "apply_patch", "create_file", + "insert_edit_into_file", + "replace_string_in_file", + "multi_replace_string_in_file", "edit_notebook_file", "create_new_jupyter_notebook", "mcp_github_create_or_update_file", "mcp_io_github_git_create_or_update_file", } -def walk(value): - if isinstance(value, dict): - for key, item in value.items(): - yield str(key) - yield from walk(item) - elif isinstance(value, list): - for item in value: - yield from walk(item) - elif isinstance(value, str): - yield value +# File extensions that require running the Python validation suite. +code_suffixes = (".py", ".toml", ".cfg", ".ini", ".yaml", ".yml", ".json") raw = os.environ.get("HOOK_PAYLOAD", "").strip() if not raw: @@ -43,11 +37,37 @@ except json.JSONDecodeError: print("skip") raise SystemExit(0) -haystack = "\n".join(s.lower() for s in walk(data)) -if any(token in haystack for token in edit_tool_tokens): - print("run") -else: +tool_name = str(data.get("tool_name") or data.get("toolName") or "").lower() +if tool_name not in edit_tools: print("skip") + raise SystemExit(0) + + +def paths(value): + """Yield path-like strings from tool input.""" + if isinstance(value, dict): + for key, item in value.items(): + if key in {"filePath", "file_path", "path", "notebookPath"} and isinstance( + item, str + ): + yield item + else: + yield from paths(item) + elif isinstance(value, list): + for item in value: + yield from paths(item) + + +tool_input = data.get("tool_input") or data.get("toolInput") or {} +edited = list(paths(tool_input)) + +# Only run the heavy validation when code/config files were touched. +# Docs, markdown, and memory edits do not need pytest + prek. +if edited and not any(p.lower().endswith(code_suffixes) for p in edited): + print("skip") + raise SystemExit(0) + +print("run") PY )" @@ -64,7 +84,7 @@ if ! uv run pytest --no-cov; then fi echo "[hook] Running prek" -if ! uv run prek run --all-files; then +if ! SKIP=no-commit-to-branch uv run prek run --all-files; then echo "[hook] Prek failed" exit 2 fi diff --git a/.github/prompts/opsx-apply.prompt.md b/.github/prompts/opsx-apply.prompt.md new file mode 100644 index 00000000..5bd0b6bb --- /dev/null +++ b/.github/prompts/opsx-apply.prompt.md @@ -0,0 +1,152 @@ +--- +description: Implement tasks from an OpenSpec change (Experimental) +--- + +Implement tasks from an OpenSpec change. + +**Store selection:** If the user names a store (a store is a standalone OpenSpec repo registered on this machine) or the work lives in one, run `openspec store list --json` to discover registered store ids, then pass `--store ` on the commands that read or write specs and changes (`new change`, `status`, `instructions`, `list`, `show`, `validate`, `archive`, `doctor`, `context`). Other commands do not take the flag. Hints printed by commands already carry the flag; keep it on follow-ups. Without a store, commands act on the nearest local `openspec/` root. + +**Input**: Optionally specify a change name (e.g., `/opsx:apply add-auth`). If omitted, check if it can be inferred from conversation context. If vague or ambiguous you MUST prompt for available changes. + +**Steps** + +1. **Select the change** + + If a name is provided, use it. Otherwise: + - Infer from conversation context if the user mentioned a change + - Auto-select if only one active change exists + - If ambiguous, run `openspec list --json` to get available changes and use the **AskUserQuestion tool** to let the user select + + Always announce: "Using change: " and how to override (e.g., `/opsx:apply `). + +2. **Check status to understand the schema** + ```bash + openspec status --change "" --json + ``` + Parse the JSON to understand: + - `schemaName`: The workflow being used (e.g., "spec-driven") + - `planningHome`, `changeRoot`, and `actionContext`: planning scope and edit constraints + - Which artifact contains the tasks (typically "tasks" for spec-driven, check status for others) + +3. **Get apply instructions** + + ```bash + openspec instructions apply --change "" --json + ``` + + This returns: + - `contextFiles`: artifact ID -> array of concrete file paths (varies by schema) + - Progress (total, complete, remaining) + - Task list with status + - Dynamic instruction based on current state + + **Handle states:** + - If `state: "blocked"` (missing artifacts): show message, suggest using `/opsx:continue` + - If `state: "all_done"`: congratulate, suggest archive + - Otherwise: proceed to implementation + +4. **Read context files** + + Read every file path listed under `contextFiles` from the apply instructions output. + The files depend on the schema being used: + - **spec-driven**: proposal, specs, design, tasks + - Other schemas: follow the contextFiles from CLI output + +5. **Show current progress** + + Display: + - Schema being used + - Progress: "N/M tasks complete" + - Remaining tasks overview + - Dynamic instruction from CLI + +6. **Implement tasks (loop until done or blocked)** + + For each pending task: + - Show which task is being worked on + - Make the code changes required + - Keep changes minimal and focused + - Mark task complete in the tasks file: `- [ ]` → `- [x]` + - Continue to next task + + **Pause if:** + - Task is unclear → ask for clarification + - Implementation reveals a design issue → suggest updating artifacts + - Error or blocker encountered → report and wait for guidance + - User interrupts + +7. **On completion or pause, show status** + + Display: + - Tasks completed this session + - Overall progress: "N/M tasks complete" + - If all done: suggest archive + - If paused: explain why and wait for guidance + +**Output During Implementation** + +``` +## Implementing: (schema: ) + +Working on task 3/7: +[...implementation happening...] +✓ Task complete + +Working on task 4/7: +[...implementation happening...] +✓ Task complete +``` + +**Output On Completion** + +``` +## Implementation Complete + +**Change:** +**Schema:** +**Progress:** 7/7 tasks complete ✓ + +### Completed This Session +- [x] Task 1 +- [x] Task 2 +... + +All tasks complete! You can archive this change with `/opsx:archive`. +``` + +**Output On Pause (Issue Encountered)** + +``` +## Implementation Paused + +**Change:** +**Schema:** +**Progress:** 4/7 tasks complete + +### Issue Encountered + + +**Options:** +1.