From b154da31289179a3490d862a16aed53bb5177f32 Mon Sep 17 00:00:00 2001 From: Christian Heel <66922325+heelc29@users.noreply.github.com> Date: Tue, 17 Feb 2026 19:17:19 -0600 Subject: [PATCH] [4.x] resolve PHPUnit Notices --- Tests/CookieTest.php | 10 +++++----- Tests/FilesTest.php | 14 +++++++------- Tests/InputTest.php | 2 ++ Tests/JsonTest.php | 6 +++--- 4 files changed, 17 insertions(+), 15 deletions(-) diff --git a/Tests/CookieTest.php b/Tests/CookieTest.php index bfd5dfe0..fd460f75 100644 --- a/Tests/CookieTest.php +++ b/Tests/CookieTest.php @@ -67,12 +67,12 @@ public function test__constructDefaultBehaviour() public function test__constructDependencyInjection() { $src = ['foo' => 'bar']; - $mockFilter = $this->createMock(InputFilter::class); + $stubFilter = $this->createStub(InputFilter::class); - $instance = new Cookie($src, ['filter' => $mockFilter]); + $instance = new Cookie($src, ['filter' => $stubFilter]); $this->assertSame($src, TestHelper::getValue($instance, 'data')); - $this->assertSame($mockFilter, TestHelper::getValue($instance, 'filter')); + $this->assertSame($stubFilter, TestHelper::getValue($instance, 'filter')); } /** @@ -83,9 +83,9 @@ public function test__constructDependencyInjection() */ public function testSetWithNewSignature() { - $mockFilter = $this->createMock(InputFilter::class); + $stubFilter = $this->createStub(InputFilter::class); - $instance = new Cookie([], ['filter' => $mockFilter]); + $instance = new Cookie([], ['filter' => $stubFilter]); $instance->set('foo', 'bar', ['expire' => 15, 'samesite' => 'Strict']); $this->assertTrue(CookieDataStore::has('foo')); diff --git a/Tests/FilesTest.php b/Tests/FilesTest.php index e8718fe8..db0a64f1 100644 --- a/Tests/FilesTest.php +++ b/Tests/FilesTest.php @@ -40,12 +40,12 @@ public function test__constructDefaultBehaviour() public function test__constructDependencyInjection() { $src = ['foo' => 'bar']; - $mockFilter = $this->createMock(InputFilter::class); + $stubFilter = $this->createStub(InputFilter::class); - $instance = new Files($src, ['filter' => $mockFilter]); + $instance = new Files($src, ['filter' => $stubFilter]); $this->assertSame($src, TestHelper::getValue($instance, 'data')); - $this->assertSame($mockFilter, TestHelper::getValue($instance, 'filter')); + $this->assertSame($stubFilter, TestHelper::getValue($instance, 'filter')); } /** @@ -73,9 +73,9 @@ public function testGet() ], ]; - $mockFilter = $this->createMock(InputFilter::class); + $stubFilter = $this->createStub(InputFilter::class); - $instance = new Files($data, ['filter' => $mockFilter]); + $instance = new Files($data, ['filter' => $stubFilter]); $this->assertEquals('foobar', $instance->get('myfile3', 'foobar'), 'The default value is returned if data does not exist.'); @@ -110,9 +110,9 @@ public function testGetWithMultiLevelData() ], ]; - $mockFilter = $this->createMock(InputFilter::class); + $stubFilter = $this->createStub(InputFilter::class); - $instance = new Files($data, ['filter' => $mockFilter]); + $instance = new Files($data, ['filter' => $stubFilter]); $this->assertEquals( [ diff --git a/Tests/InputTest.php b/Tests/InputTest.php index bbe9b98a..0ae4698d 100644 --- a/Tests/InputTest.php +++ b/Tests/InputTest.php @@ -10,6 +10,7 @@ use Joomla\Filter\InputFilter; use Joomla\Input\Input; use Joomla\Test\TestHelper; +use PHPUnit\Framework\Attributes\AllowMockObjectsWithoutExpectations; use PHPUnit\Framework\Attributes\DataProvider; use PHPUnit\Framework\MockObject\MockObject; use PHPUnit\Framework\TestCase; @@ -18,6 +19,7 @@ /** * Test class for \Joomla\Input\Input. */ +#[AllowMockObjectsWithoutExpectations] class InputTest extends TestCase { /** diff --git a/Tests/JsonTest.php b/Tests/JsonTest.php index c411a6cc..2c90e250 100644 --- a/Tests/JsonTest.php +++ b/Tests/JsonTest.php @@ -40,12 +40,12 @@ public function test__constructDefaultBehaviour() public function test__constructDependencyInjection() { $src = ['foo' => 'bar']; - $mockFilter = $this->createMock(InputFilter::class); + $stubFilter = $this->createStub(InputFilter::class); - $instance = new Json($src, ['filter' => $mockFilter]); + $instance = new Json($src, ['filter' => $stubFilter]); $this->assertSame($src, TestHelper::getValue($instance, 'data')); - $this->assertSame($mockFilter, TestHelper::getValue($instance, 'filter')); + $this->assertSame($stubFilter, TestHelper::getValue($instance, 'filter')); } /**